Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak tests timeouts #3514

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Tweak tests timeouts #3514

merged 2 commits into from
Oct 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 6, 2023 •
edited
Loading

Description

It lists stuck tests now: https://github.com/FerretDB/FerretDB/actions/runs/6431370762/job/17464147996?pr=3514

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #3514 (726ddd1) into main (360e147) will decrease coverage by 67.18%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3514       +/-   ##
==========================================
- Coverage   71.71%   4.54%   -67.18%     
==========================================
  Files         426     420        -6     
  Lines       26946   26628      -318     
==========================================
- Hits        19325    1209    -18116     
- Misses       6385   25338    +18953     
+ Partials     1236      81     -1155

see 319 files with indirect coverage changes

Flag Coverage Δ
filter-true 4.54% <ø> (-60.94%) ⬇️
hana-1 ?
integration 4.54% <ø> (-60.94%) ⬇️
mongodb-1 4.54% <ø> (ø)
pg-2 ?
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 4.54% <ø> (-60.94%) ⬇️
sqlite-1 ?
sqlite-2 ?
sqlite-3 ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 6, 2023
@AlekSi AlekSi added this to the Next milestone Oct 6, 2023
@AlekSi AlekSi marked this pull request as ready for review October 6, 2023 12:30
@AlekSi AlekSi enabled auto-merge (squash) October 6, 2023 12:31
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 6, 2023 12:31
rumyantseva
rumyantseva approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge October 6, 2023 12:38
@AlekSi AlekSi merged commit ae1c201 into FerretDB:main Oct 6, 2023
26 of 30 checks passed
@AlekSi AlekSi deleted the timeouts branch October 6, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva