Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow importing handlers code from backends #3512

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Disallow importing handlers code from backends #3512

merged 4 commits into from
Oct 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 6, 2023

Description

Except sjson.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 6, 2023
@AlekSi AlekSi added this to the Next milestone Oct 6, 2023
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 6, 2023 09:39
@AlekSi AlekSi self-assigned this Oct 6, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 6, 2023 09:40
@AlekSi AlekSi mentioned this pull request Oct 6, 2023
Merged
9 tasks
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #3512 (8b8a795) into main (ee729a0) will decrease coverage by 1.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3512      +/-   ##
==========================================
- Coverage   74.08%   72.12%   -1.96%     
==========================================
  Files         426      426              
  Lines       26963    26963              
==========================================
- Hits        19975    19448     -527     
- Misses       5799     6312     +513     
- Partials     1189     1203      +14

see 34 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.03% <ø> (-4.64%) ⬇️
hana-1 ?
integration 66.03% <ø> (-4.64%) ⬇️
mongodb-1 4.53% <ø> (ø)
pg-1 39.20% <ø> (ø)
pg-2 ∅ <ø> (∅)
pg-3 42.73% <ø> (ø)
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 66.03% <ø> (-4.64%) ⬇️
sqlite-1 38.37% <ø> (ø)
sqlite-2 41.56% <ø> (-0.01%) ⬇️
sqlite-3 42.12% <ø> (ø)
unit 25.78% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

rumyantseva
rumyantseva approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

.golangci.yml Show resolved Hide resolved
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 6, 2023
@AlekSi AlekSi merged commit bfa7300 into FerretDB:main Oct 6, 2023
41 of 56 checks passed
@AlekSi AlekSi deleted the tweak-linters branch October 6, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow