Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index name generation #3511

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Fix index name generation #3511

merged 5 commits into from
Oct 9, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 6, 2023 •
edited
Loading

Description

Closes #3375.

Passed:

 task test-integration-postgresql SHARD_INDEX=0 SHARD_TOTAL=0 TEST_RUN='TestAggregateCompatGroup'

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Oct 6, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Oct 6, 2023
@rumyantseva rumyantseva added this to the Next milestone Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #3511 (185672a) into main (3502cc0) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
+ Coverage   74.84%   74.90%   +0.06%     
==========================================
  Files         426      426              
  Lines       26966    26968       +2     
==========================================
+ Hits        20182    20200      +18     
+ Misses       5609     5566      -43     
- Partials     1175     1202      +27
Files Coverage Δ
internal/backends/postgresql/metadata/registry.go 71.47% <100.00%> (+6.37%) ⬆️

... and 25 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 71.78% <100.00%> (+0.16%) ⬆️
hana-1 ?
integration 71.78% <100.00%> (+0.11%) ⬆️
mongodb-1 4.53% <0.00%> (-0.01%) ⬇️
pg-1 39.16% <0.00%> (-0.52%) ⬇️
pg-2 42.26% <0.00%> (-0.45%) ⬇️
pg-3 42.63% <0.00%> (-0.64%) ⬇️
postgresql-1 38.84% <100.00%> (+19.96%) ⬆️
postgresql-2 40.85% <100.00%> (+24.98%) ⬆️
postgresql-3 42.44% <100.00%> (+21.78%) ⬆️
sort-false 71.78% <100.00%> (+0.69%) ⬆️
sort-true ?
sqlite-1 38.36% <0.00%> (-0.05%) ⬇️
sqlite-2 41.47% <0.00%> (-0.12%) ⬇️
sqlite-3 42.07% <0.00%> (-0.07%) ⬇️
unit 25.72% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow previously approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rumyantseva rumyantseva requested review from a team and noisersup October 6, 2023 08:19
@rumyantseva rumyantseva marked this pull request as ready for review October 6, 2023 08:19
@rumyantseva rumyantseva requested a review from AlekSi as a code owner October 6, 2023 08:19
@rumyantseva rumyantseva enabled auto-merge (squash) October 6, 2023 08:19
@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 6, 2023
@rumyantseva
Copy link
Contributor Author

Not ready yet, tests to be added

AlekSi
AlekSi reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request when ready

@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 6, 2023
@rumyantseva rumyantseva mentioned this pull request Oct 9, 2023
Merged
9 tasks
noisersup
noisersup approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit 4ac2235 into FerretDB:main Oct 9, 2023
26 of 29 checks passed
@rumyantseva rumyantseva deleted the bugfix branch October 9, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Store index metadata
4 participants
@rumyantseva @AlekSi @chilagrow @noisersup