Codecov Report

Merging #3508 (824efc4) into main (b932d0f) will decrease coverage by 6.29%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3508      +/-   ##
==========================================
- Coverage   73.54%   67.25%   -6.29%     
==========================================
  Files         427      427              
  Lines       27122    27124       +2     
==========================================
- Hits        19946    18242    -1704     
- Misses       5983     7613    +1630     
- Partials     1193     1269      +76     

... and 74 files with indirect coverage changes

Flags with carried forward coverage won't be shown. Click here to find out more.

👋 @princejha95 I also imported same fix to the aggregation $project stage 🤗

@chilagrow I also think that in future, we should create a constants file which will store string constants like _id otherwise we will be using strings everywhere and we need to make change everywhere if there's a change in string value. What are your suggestions on this ? Can it be a improvement task ?

Thanks

@princejha95 could you give an example of what change in string value might be needed in the future, please?

@princejha95 could you give an example of what change in string value might be needed in the future, please?

What i meant was if we create a file like MongoConstants.go and define a constant like MONGO_ID = "_id", then we can use MONGO_ID everywhere instead of "_id" as it might get written wrongly by mistake. So it's a good practice to keep all such constants which never gets changed inside a file and use them everywhere from the file itself. Generally it is considered a good practice.

Thanks

@princejha95 could you give an example of what change in string value might be needed in the future, please?

What i meant was if we create a file like MongoConstants.go and define a constant like MONGO_ID = "_id", then we can use MONGO_ID everywhere instead of "_id" as it might get written wrongly by mistake. So it's a good practice to keep all such constants which never gets changed inside a file and use them everywhere from the file itself. Generally it is considered a good practice.

Thanks

👋 @princejha95 thanks for your comment. For a short one like _id, creating a constant for it doesn't add additional context. Also it's hard to mistype without tests failing somewhere. 🤗 So I don't think it's necessary for _id.