Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract ReservedPrefix constant #3497

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Extract ReservedPrefix constant #3497

merged 3 commits into from
Oct 5, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 4, 2023

Description

Just a small clean-up before we use it in more places.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 4, 2023
@AlekSi AlekSi added this to the Next milestone Oct 4, 2023
@AlekSi AlekSi self-assigned this Oct 4, 2023
@AlekSi AlekSi enabled auto-merge (squash) October 4, 2023 13:57
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 4, 2023 13:57
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #3497 (5f98f3f) into main (0a56f5b) will increase coverage by 46.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3497       +/-   ##
===========================================
+ Coverage   27.00%   73.91%   +46.90%     
===========================================
  Files         424      424               
  Lines       26548    26546        -2     
===========================================
+ Hits         7169    19621    +12452     
+ Misses      18707     5761    -12946     
- Partials      672     1164      +492
Files Coverage Δ
internal/backends/postgresql/metadata/registry.go 66.81% <ø> (+0.51%) ⬆️
internal/backends/sqlite/metadata/metadata.go 72.72% <ø> (ø)
internal/backends/sqlite/metadata/registry.go 70.17% <ø> (+8.52%) ⬆️
internal/backends/validation.go 52.63% <0.00%> (+31.57%) ⬆️

... and 222 files with indirect coverage changes

Flag Coverage Δ
filter-true 68.71% <0.00%> (+63.47%) ⬆️
hana-1 ?
integration 68.71% <0.00%> (+63.47%) ⬆️
mongodb-1 4.60% <0.00%> (+<0.01%) ⬆️
pg-1 40.37% <0.00%> (∅)
pg-2 42.90% <0.00%> (∅)
pg-3 42.64% <0.00%> (?)
postgresql-1 ∅ <ø> (?)
postgresql-2 ∅ <ø> (?)
postgresql-3 ∅ <ø> (?)
sort-false 68.71% <0.00%> (+63.47%) ⬆️
sqlite-1 39.48% <0.00%> (?)
sqlite-2 42.21% <0.00%> (?)
sqlite-3 42.14% <0.00%> (?)
unit 25.20% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from rumyantseva and a team October 5, 2023 07:42
rumyantseva
rumyantseva approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit a2f93bc into FerretDB:main Oct 5, 2023
@AlekSi AlekSi deleted the reserved-prefix branch October 5, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow