Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable auto_vacuum for SQLite #3496

Merged
merged 15 commits into from
Oct 6, 2023
Merged

Disable auto_vacuum for SQLite #3496

merged 15 commits into from
Oct 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 4, 2023

Description

Refs #3469.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 4, 2023
@AlekSi AlekSi added this to the Next milestone Oct 4, 2023
@AlekSi AlekSi self-assigned this Oct 4, 2023
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 4, 2023 13:51
@AlekSi AlekSi enabled auto-merge (squash) October 4, 2023 13:51
noisersup
noisersup previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #3496 (1eec088) into main (4002677) will decrease coverage by 7.16%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
- Coverage   72.31%   65.15%   -7.16%     
==========================================
  Files         426      426              
  Lines       26963    26969       +6     
==========================================
- Hits        19497    17572    -1925     
- Misses       6224     8103    +1879     
- Partials     1242     1294      +52
Files Coverage Δ
internal/backends/sqlite/metadata/pool/uri.go 85.71% <57.14%> (-3.76%) ⬇️

... and 114 files with indirect coverage changes

Flag Coverage Δ
filter-true 58.58% <57.14%> (-10.19%) ⬇️
hana-1 ?
integration 58.58% <57.14%> (-10.19%) ⬇️
mongodb-1 4.53% <0.00%> (-0.01%) ⬇️
pg-1 ∅ <ø> (∅)
pg-2 ∅ <ø> (∅)
pg-3 42.72% <0.00%> (-0.01%) ⬇️
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 58.58% <57.14%> (-10.19%) ⬇️
sqlite-1 38.37% <57.14%> (?)
sqlite-2 ?
sqlite-3 42.12% <57.14%> (?)
unit 25.68% <57.14%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rumyantseva
Copy link
Contributor

I approve as the changes look good to me, but some tests fail.

chilagrow
chilagrow reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the failing tests https://github.com/FerretDB/FerretDB/actions/runs/6410291230/job/17403285801?pr=3496, I think auto vacuum is locking the database.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 5, 2023
@AlekSi AlekSi dismissed stale reviews from noisersup and rumyantseva via 8fce2e9 October 5, 2023 07:25
@AlekSi AlekSi changed the title Enable auto_vacuum for SQLite Disable auto_vacuum for SQLite Oct 5, 2023
@AlekSi AlekSi disabled auto-merge October 5, 2023 07:31
@AlekSi AlekSi enabled auto-merge (squash) October 5, 2023 07:31
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 5, 2023
@AlekSi AlekSi requested review from noisersup, rumyantseva, chilagrow and a team October 5, 2023 07:31
rumyantseva
rumyantseva previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, the tests still fail though.

@AlekSi AlekSi marked this pull request as draft October 5, 2023 09:24
auto-merge was automatically disabled October 5, 2023 09:24

Pull request was converted to draft

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 5, 2023
@AlekSi AlekSi dismissed stale reviews from chilagrow and rumyantseva via a66363d October 5, 2023 14:02
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 5, 2023
@AlekSi AlekSi marked this pull request as ready for review October 5, 2023 15:40
@AlekSi AlekSi enabled auto-merge (squash) October 5, 2023 15:40
@AlekSi AlekSi requested review from rumyantseva, chilagrow and a team October 5, 2023 15:40
rumyantseva
rumyantseva approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 6, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 6, 2023
@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 6, 2023
@AlekSi AlekSi merged commit 50fc27d into FerretDB:main Oct 6, 2023
48 of 73 checks passed
@AlekSi AlekSi deleted the autovacuum branch October 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup