Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revive logic of lower cased key for collection name #3494

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Revive logic of lower cased key for collection name #3494

merged 6 commits into from
Oct 4, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Oct 4, 2023 •
edited
Loading

Description

Closes #2786.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Oct 4, 2023
@chilagrow chilagrow added this to the Next milestone Oct 4, 2023
@chilagrow chilagrow self-assigned this Oct 4, 2023
@chilagrow chilagrow changed the title Review logic for lower cased key of collection name Revive logic for lower cased key of collection name Oct 4, 2023
@chilagrow chilagrow changed the title Revive logic for lower cased key of collection name Revive logic for lower cased key for collection name Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #3494 (631ef30) into main (68ac650) will decrease coverage by 0.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3494      +/-   ##
==========================================
- Coverage   74.06%   73.17%   -0.90%     
==========================================
  Files         424      424              
  Lines       26533    26539       +6     
==========================================
- Hits        19651    19419     -232     
- Misses       5721     5941     +220     
- Partials     1161     1179      +18
Files Coverage Δ
internal/handlers/commonparams/extract_params.go 82.97% <100.00%> (+0.37%) ⬆️

... and 21 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.84% <100.00%> (-1.05%) ⬇️
hana-1 ?
integration 67.84% <100.00%> (-1.05%) ⬇️
mongodb-1 4.60% <0.00%> (-0.01%) ⬇️
pg-1 ?
pg-2 43.00% <100.00%> (+0.02%) ⬆️
pg-3 42.65% <100.00%> (+0.01%) ⬆️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ?
postgresql-3 ?
sort-false 67.84% <100.00%> (-1.05%) ⬇️
sqlite-1 39.51% <100.00%> (+0.01%) ⬆️
sqlite-2 42.12% <100.00%> (+0.01%) ⬆️
sqlite-3 42.15% <100.00%> (+0.01%) ⬆️
unit 25.17% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review October 4, 2023 03:59
@chilagrow chilagrow requested a review from a team as a code owner October 4, 2023 03:59
@chilagrow chilagrow enabled auto-merge (squash) October 4, 2023 03:59
@chilagrow chilagrow requested review from a team and noisersup October 4, 2023 03:59
@chilagrow chilagrow changed the title Revive logic for lower cased key for collection name Revive logic of lower cased key for collection name Oct 4, 2023
@chilagrow chilagrow mentioned this pull request Oct 4, 2023
Merged
9 tasks
AlekSi
AlekSi reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update TestMostCommandsAreCaseSensitive with findandmodify (and dbstats, while we are on it)

@chilagrow chilagrow requested a review from AlekSi October 4, 2023 04:31
noisersup
noisersup approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit d05546d into FerretDB:main Oct 4, 2023
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Process collection name parameter in tags
3 participants
@chilagrow @AlekSi @noisersup