Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stubs for Collection.Compact #3485

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Add stubs for Collection.Compact #3485

merged 2 commits into from
Oct 3, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 3, 2023 •
edited
Loading

Description

Refs #75.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 3, 2023
@AlekSi AlekSi added this to the Next milestone Oct 3, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 3, 2023
@AlekSi AlekSi marked this pull request as ready for review October 3, 2023 06:09
@AlekSi AlekSi enabled auto-merge (squash) October 3, 2023 06:09
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup October 3, 2023 06:09
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #3485 (2cd38b3) into main (dd6e9dd) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3485      +/-   ##
==========================================
- Coverage   74.68%   74.10%   -0.59%     
==========================================
  Files         422      422              
  Lines       26374    26393      +19     
==========================================
- Hits        19697    19558     -139     
- Misses       5544     5680     +136     
- Partials     1133     1155      +22
Files Coverage Δ
internal/backends/decorators/dummy/collection.go 0.00% <0.00%> (ø)
internal/backends/decorators/oplog/collection.go 0.00% <0.00%> (ø)
internal/backends/hana/collection.go 0.00% <0.00%> (ø)
internal/backends/postgresql/collection.go 18.02% <0.00%> (-0.32%) ⬇️
internal/backends/sqlite/collection.go 78.70% <0.00%> (-0.87%) ⬇️
internal/backends/collection.go 91.25% <0.00%> (-8.75%) ⬇️

... and 16 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 69.10% <0.00%> (-0.65%) ⬇️
hana-1 ?
integration 69.10% <0.00%> (-0.70%) ⬇️
mongodb-1 4.63% <0.00%> (-0.01%) ⬇️
pg-1 40.55% <0.00%> (-0.58%) ⬇️
pg-2 43.22% <0.00%> (-0.49%) ⬇️
pg-3 42.87% <0.00%> (-0.66%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 69.10% <0.00%> (-0.28%) ⬇️
sort-true ?
sqlite-1 39.72% <0.00%> (-0.06%) ⬇️
sqlite-2 42.34% <0.00%> (-0.14%) ⬇️
sqlite-3 42.37% <0.00%> (-0.07%) ⬇️
unit 25.03% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just one comment

internal/backends/collection.go Outdated Show resolved Hide resolved
chilagrow
chilagrow previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@AlekSi AlekSi requested review from chilagrow and a team October 3, 2023 06:30
chilagrow
chilagrow approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AlekSi AlekSi disabled auto-merge October 3, 2023 09:48
@AlekSi AlekSi merged commit 531f91c into FerretDB:main Oct 3, 2023
27 of 31 checks passed
@AlekSi AlekSi deleted the compact branch October 3, 2023 09:48
@AlekSi AlekSi mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow