Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filter pushdown #3482

Merged
merged 26 commits into from
Oct 9, 2023
Merged

Implement filter pushdown #3482

merged 26 commits into from
Oct 9, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Oct 2, 2023 •
edited by AlekSi
Loading

Description

Closes #3414.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #3482 (32a8c18) into main (4ac2235) will decrease coverage by 0.11%.
The diff coverage is 86.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3482      +/-   ##
==========================================
- Coverage   75.03%   74.93%   -0.11%     
==========================================
  Files         426      427       +1     
  Lines       26968    27119     +151     
==========================================
+ Hits        20235    20321      +86     
- Misses       5533     5588      +55     
- Partials     1200     1210      +10
Files Coverage Δ
internal/backends/postgresql/collection.go 67.97% <71.87%> (-0.18%) ⬇️
internal/backends/postgresql/query.go 90.51% <90.51%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.85% <86.98%> (-0.07%) ⬇️
hana-1 ?
integration 71.85% <86.98%> (-0.07%) ⬇️
mongodb-1 4.50% <0.00%> (-0.03%) ⬇️
pg-1 38.95% <0.00%> (-0.22%) ⬇️
pg-2 41.98% <0.00%> (-0.15%) ⬇️
pg-3 42.39% <0.00%> (-0.25%) ⬇️
postgresql-1 39.01% <66.86%> (+0.16%) ⬆️
postgresql-2 42.06% <76.33%> (+0.49%) ⬆️
postgresql-3 42.44% <73.37%> (+0.47%) ⬆️
sort-false 71.85% <86.98%> (-0.07%) ⬇️
sqlite-1 38.15% <0.00%> (-0.22%) ⬇️
sqlite-2 41.24% <0.00%> (-0.33%) ⬇️
sqlite-3 41.84% <0.00%> (-0.23%) ⬇️
unit 25.93% <59.17%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Oct 3, 2023
@noisersup noisersup marked this pull request as ready for review October 3, 2023 13:08
@noisersup noisersup requested a review from AlekSi as a code owner October 3, 2023 13:08
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 4, 2023
@AlekSi AlekSi added this to the Next milestone Oct 4, 2023
AlekSi
AlekSi reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict now

@noisersup noisersup requested review from a team and rumyantseva October 4, 2023 12:45
@AlekSi AlekSi enabled auto-merge (squash) October 4, 2023 15:37
AlekSi
AlekSi reviewed Oct 4, 2023
View reviewed changes
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from AlekSi October 4, 2023 21:50
chilagrow
chilagrow reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just question about test

internal/backends/postgresql/query.go Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task fmt lint

@noisersup noisersup requested review from AlekSi and chilagrow October 5, 2023 13:46
@AlekSi AlekSi requested review from a team October 5, 2023 15:32
AlekSi
AlekSi reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3482 (comment)

@noisersup noisersup requested a review from AlekSi October 5, 2023 21:33
@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 6, 2023
@noisersup noisersup requested a review from chilagrow October 8, 2023 00:04
@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 8, 2023
rumyantseva
rumyantseva approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/backends/postgresql/query.go Show resolved Hide resolved
internal/backends/postgresql/query.go Show resolved Hide resolved
@AlekSi AlekSi merged commit 35f5849 into FerretDB:main Oct 9, 2023
26 of 29 checks passed
@AlekSi AlekSi changed the title Implement filter pushdown for PostgreSQL Implement filter pushdown Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@noisersup noisersup

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement filter pushdown
4 participants
@noisersup @AlekSi @rumyantseva @chilagrow