Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build arm64 binaries and packages #3477

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Build arm64 binaries and packages #3477

merged 2 commits into from
Oct 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 2, 2023 •
edited
Loading

Description

Refs #2171.

It is tricky to test on CI before merging this PR, so let's just merge it.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 2, 2023
@AlekSi AlekSi added this to the Next milestone Oct 2, 2023
@AlekSi AlekSi self-assigned this Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #3477 (b3b0291) into main (b9c8dd8) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3477      +/-   ##
==========================================
- Coverage   74.30%   74.17%   -0.13%     
==========================================
  Files         422      422              
  Lines       26374    26374              
==========================================
- Hits        19597    19563      -34     
- Misses       5624     5656      +32     
- Partials     1153     1155       +2

see 5 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.18% <ø> (-0.14%) ⬇️
hana-1 ?
integration 69.18% <ø> (-0.14%) ⬇️
mongodb-1 4.63% <ø> (ø)
pg-1 40.61% <ø> (ø)
pg-2 43.15% <ø> (ø)
pg-3 42.90% <ø> (ø)
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 69.18% <ø> (-0.14%) ⬇️
sqlite-1 39.74% <ø> (ø)
sqlite-2 42.47% <ø> (+0.09%) ⬆️
sqlite-3 42.40% <ø> (ø)
unit 25.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 2, 2023 07:01
@AlekSi AlekSi requested a review from ptrfarkas as a code owner October 2, 2023 07:01
@AlekSi AlekSi enabled auto-merge (squash) October 2, 2023 07:01
chilagrow
chilagrow approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let's merge it 👍

@AlekSi AlekSi disabled auto-merge October 2, 2023 07:25
@AlekSi AlekSi merged commit 85626b8 into FerretDB:main Oct 2, 2023
28 of 32 checks passed
@AlekSi AlekSi deleted the docker-binaries branch October 2, 2023 07:25
princejha95 pushed a commit to princejha95/FerretDB that referenced this pull request Oct 3, 2023
@AlekSi @princejha95
Build arm64 binaries and packages (FerretDB#3477)
2b3c7c8
@AlekSi AlekSi added code/feature Some user-visible feature is not implemented yet and removed code/chore Code maintenance improvements labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@Fashander Fashander Awaiting requested review from Fashander Fashander was automatically assigned from FerretDB/docs

Assignees

@AlekSi AlekSi

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow