Process collection name param using collection tag
#3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3476 +/- ##
==========================================
- Coverage 74.61% 74.07% -0.55%
==========================================
Files 422 422
Lines 26393 26394 +1
==========================================
- Hits 19694 19551 -143
- Misses 5565 5686 +121
- Partials 1134 1157 +23
... and 19 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
reviewed
Oct 2, 2023
…/collection-param-tag
…ii/FerretDB into fix/collection-param-tag
chilagrow
reviewed
Oct 3, 2023
|
By the way, when you are ready to request review again, you can press this button. It will notify reviewers 🤗 |
…/collection-param-tag
…ii/FerretDB into fix/collection-param-tag
chilagrow
approved these changes
Oct 4, 2023
chilagrow
approved these changes
Oct 4, 2023
AlekSi
approved these changes
Oct 4, 2023
AlekSi
reviewed
Oct 4, 2023
| @@ -87,12 +84,6 @@ func ExtractParams(doc *types.Document, command string, value any, l *zap.Logger | |||
|
|
|||
| lookup := key | |||
|
|
|||
| // If the key is the same as the command name, then it is a collection name. | |||
| // Depending on the driver, the key may be camel case or lower case for a collection name. | |||
There was a problem hiding this comment.
Thanks for capturing this. Fix made in #3494
| @@ -44,7 +44,7 @@ const ( | |||
| // FindAndModifyParams represent parameters for the findAndModify command. | |||
| type FindAndModifyParams struct { | |||
| DB string `ferretdb:"$db"` | |||
| Collection string `ferretdb:"collection"` | |||
| Collection string `ferretdb:"findAndModify,collection"` | |||
There was a problem hiding this comment.
Some drivers send this as findandmodify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2786.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.