Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add operation mode definition to Glossary #3472

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Add operation mode definition to Glossary #3472

merged 9 commits into from
Oct 5, 2023

Conversation

rohitkbc
Copy link
Contributor

@rohitkbc rohitkbc commented Oct 1, 2023 •
edited by Fashander
Loading

Description

Closes #3445.

This PR added glossary of operation mode in Glossary.md file.

image

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlekSi AlekSi added this to the Next milestone Oct 2, 2023
@AlekSi AlekSi requested review from a team and Fashander October 2, 2023 07:12
@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label Oct 2, 2023
@Fashander Fashander enabled auto-merge (squash) October 2, 2023 11:53
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #3472 (a98a07f) into main (77409eb) will increase coverage by 48.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3472       +/-   ##
===========================================
+ Coverage   25.22%   73.28%   +48.05%     
===========================================
  Files         409      424       +15     
  Lines       25321    26553     +1232     
===========================================
+ Hits         6388    19460    +13072     
+ Misses      18296     5915    -12381     
- Partials      637     1178      +541

see 234 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.93% <ø> (?)
hana-1 2.96% <ø> (?)
integration 67.93% <ø> (?)
mongodb-1 4.63% <ø> (?)
pg-2 42.98% <ø> (?)
pg-3 42.63% <ø> (?)
sort-false 67.93% <ø> (?)
sqlite-1 39.50% <ø> (?)
sqlite-2 42.20% <ø> (?)
sqlite-3 42.13% <ø> (?)
unit 25.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Fashander
Fashander reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add a link to the Operation modes page at https://docs.ferretdb.io/configuration/operation-modes/

Here’s the writing guide for links
https://docs.ferretdb.io/contributing/writing-guide/#links

auto-merge was automatically disabled October 2, 2023 15:35

Head branch was pushed to by a user without write access

Fashander
Fashander previously approved these changes Oct 3, 2023
View reviewed changes
@Fashander Fashander enabled auto-merge (squash) October 3, 2023 05:54
AlekSi
AlekSi reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs should be reformatted using task docs-fmt because CI fails: https://github.com/FerretDB/FerretDB/actions/runs/6401617962/job/17376982130?pr=3472

@Fashander Fashander self-requested a review October 4, 2023 14:45
@Fashander Fashander requested a review from AlekSi October 4, 2023 15:22
@Fashander Fashander added the trust PRs that can access Actions secrets label Oct 5, 2023
@Fashander Fashander changed the title Added Operation mode in Glossary.md Add Operation mode definition to Glossary Oct 5, 2023
@Fashander Fashander changed the title Add Operation mode definition to Glossary Add operation mode definition to Glossary Oct 5, 2023
@Fashander Fashander merged commit 2ee74c8 into FerretDB:main Oct 5, 2023
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@Fashander Fashander

@rohitkbc rohitkbc

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Add operation modes definition to glossary list
4 participants
@rohitkbc @CLAassistant @AlekSi @Fashander