Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed-up Docker image building #3470

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Speed-up Docker image building #3470

merged 3 commits into from
Oct 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 30, 2023 •
edited
Loading

Description

Fix Go build caching. Build time went down from 24 minutes to 14.

Plus additional small clean-ups.

Refs #2170.
Closes #2179.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets packages PRs that should build packages labels Sep 30, 2023
@AlekSi AlekSi added this to the Next milestone Sep 30, 2023
@AlekSi AlekSi self-assigned this Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023 •
edited
Loading

Codecov Report

Merging #3470 (1cd92a5) into main (b10af0a) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3470      +/-   ##
==========================================
- Coverage   74.69%   74.26%   -0.43%     
==========================================
  Files         422      422              
  Lines       26374    26374              
==========================================
- Hits        19700    19587     -113     
- Misses       5542     5631      +89     
- Partials     1132     1156      +24
Files Coverage Δ
internal/util/logging/logging.go 80.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 69.27% <100.00%> (-0.49%) ⬇️
hana-1 2.98% <100.00%> (ø)
integration 69.27% <100.00%> (-0.53%) ⬇️
mongodb-1 4.63% <100.00%> (ø)
pg-1 40.61% <100.00%> (-0.52%) ⬇️
pg-2 43.15% <100.00%> (-0.55%) ⬇️
pg-3 42.90% <100.00%> (-0.63%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 69.27% <100.00%> (-0.12%) ⬇️
sort-true ?
sqlite-1 39.72% <100.00%> (-0.05%) ⬇️
sqlite-2 42.37% <100.00%> (-0.12%) ⬇️
sqlite-3 42.39% <100.00%> (-0.04%) ⬇️
unit 25.04% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review October 2, 2023 04:04
@AlekSi AlekSi requested a review from a team as a code owner October 2, 2023 04:04
@AlekSi AlekSi enabled auto-merge (squash) October 2, 2023 04:04
@AlekSi AlekSi requested review from a team and noisersup October 2, 2023 04:04
@AlekSi AlekSi disabled auto-merge October 2, 2023 05:17
@AlekSi AlekSi merged commit b9c8dd8 into FerretDB:main Oct 2, 2023
27 of 34 checks passed
@AlekSi AlekSi deleted the docker-cache branch October 2, 2023 05:18
princejha95 pushed a commit to princejha95/FerretDB that referenced this pull request Oct 3, 2023
@AlekSi @princejha95
Speed-up Docker image building (FerretDB#3470)
a3a0913 
Closes FerretDB#2179.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Use scratch for production Docker image
2 participants
@AlekSi @chilagrow