Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement explain #3465

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Implement explain #3465

merged 12 commits into from
Oct 4, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Sep 29, 2023 •
edited
Loading

Description

Closes #3389.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Sep 29, 2023
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #3465 (7832332) into main (25ea2df) will decrease coverage by 1.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
- Coverage   74.22%   73.16%   -1.06%     
==========================================
  Files         422      423       +1     
  Lines       26394    26459      +65     
==========================================
- Hits        19590    19360     -230     
- Misses       5650     5928     +278     
- Partials     1154     1171      +17
Files Coverage Δ
internal/backends/postgresql/helpers.go 0.00% <0.00%> (ø)
internal/backends/postgresql/collection.go 15.12% <0.00%> (-2.91%) ⬇️

... and 24 files with indirect coverage changes

Flag Coverage Δ
filter-true 68.03% <0.00%> (-1.19%) ⬇️
hana-1 ?
integration 68.03% <0.00%> (-1.19%) ⬇️
mongodb-1 4.62% <0.00%> (-0.02%) ⬇️
pg-1 ?
pg-2 43.10% <0.00%> (-0.11%) ⬇️
pg-3 42.76% <0.00%> (-0.11%) ⬇️
postgresql-1 ∅ <ø> (∅)
sort-false 68.03% <0.00%> (-1.19%) ⬇️
sqlite-1 39.61% <0.00%> (-0.08%) ⬇️
sqlite-2 42.23% <0.00%> (-0.21%) ⬇️
sqlite-3 42.25% <0.00%> (-0.12%) ⬇️
unit 25.02% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review September 29, 2023 13:51
@noisersup noisersup requested a review from AlekSi as a code owner September 29, 2023 13:51
@noisersup noisersup requested review from a team, rumyantseva and chilagrow September 29, 2023 13:51
@noisersup noisersup enabled auto-merge (squash) September 29, 2023 13:52
chilagrow
chilagrow reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about implementation 🙏

internal/backends/postgresql/collection.go Show resolved Hide resolved
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
internal/backends/postgresql/query_iterator.go Outdated Show resolved Hide resolved
internal/backends/postgresql/helpers.go Show resolved Hide resolved
internal/backends/postgresql/collection.go Outdated Show resolved Hide resolved
noisersup and others added 3 commits October 3, 2023 11:27
@noisersup @chilagrow
Update internal/backends/postgresql/collection.go
8a20423 
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@noisersup
wip
768b609
@noisersup
wip
9ab2c51
@noisersup noisersup requested a review from chilagrow October 3, 2023 12:01
@noisersup noisersup mentioned this pull request Oct 3, 2023
Merged
9 tasks
chilagrow
chilagrow approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🤗

internal/backends/postgresql/helpers.go Show resolved Hide resolved
@AlekSi AlekSi changed the title Implement explain for new postgresql backend Implement explain Oct 4, 2023
@AlekSi AlekSi added this to the Next milestone Oct 4, 2023
@AlekSi
Copy link
Member

AlekSi commented Oct 4, 2023

@noisersup

(for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.

The milestone wasn't set

@noisersup noisersup merged commit bc7888e into FerretDB:main Oct 4, 2023
24 of 29 checks passed
@noisersup noisersup deleted the explain-new-pg-3389 branch October 4, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement Explain
3 participants
@noisersup @AlekSi @chilagrow