Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement database.Stats #3464

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Implement database.Stats #3464

merged 11 commits into from
Oct 4, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Sep 29, 2023 •
edited
Loading

Description

Closes #3402.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Sep 29, 2023
@chilagrow chilagrow added this to the Next milestone Sep 29, 2023
@chilagrow chilagrow self-assigned this Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #3464 (9a6caff) into main (85626b8) will decrease coverage by 0.16%.
Report is 1 commits behind head on main.
The diff coverage is 72.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   74.30%   74.14%   -0.16%     
==========================================
  Files         422      423       +1     
  Lines       26374    26448      +74     
==========================================
+ Hits        19597    19610      +13     
- Misses       5624     5675      +51     
- Partials     1153     1163      +10
Files Coverage Δ
internal/backends/database.go 100.00% <ø> (ø)
internal/backends/postgresql/postgresql.go 84.21% <84.21%> (ø)
internal/backends/postgresql/database.go 42.05% <60.52%> (+8.25%) ⬆️

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 68.94% <0.00%> (-0.38%) ⬇️
hana-1 ?
integration 68.94% <0.00%> (-0.38%) ⬇️
mongodb-1 4.62% <0.00%> (-0.02%) ⬇️
pg-1 40.49% <0.00%> (-0.12%) ⬇️
pg-2 43.03% <0.00%> (-0.22%) ⬇️
pg-3 42.78% <0.00%> (-0.13%) ⬇️
postgresql-1 ?
postgresql-2 ?
postgresql-3 ?
sort-false 68.94% <0.00%> (-0.38%) ⬇️
sqlite-1 39.61% <0.00%> (-0.14%) ⬇️
sqlite-2 42.35% <0.00%> (-0.13%) ⬇️
sqlite-3 42.28% <0.00%> (-0.12%) ⬇️
unit 25.21% <72.36%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review September 29, 2023 09:09
@chilagrow chilagrow requested a review from AlekSi as a code owner September 29, 2023 09:09
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup September 29, 2023 09:09
@chilagrow chilagrow enabled auto-merge (squash) September 29, 2023 09:10
@chilagrow chilagrow mentioned this pull request Oct 2, 2023
Merged
9 tasks
@chilagrow
Copy link
Member Author

For testing, I used mongorestore with one of the dump in https://github.com/FerretDB/dance/tree/main/dumps and checked task run with --test-use-new-pg produces the same result as task run.

@AlekSi AlekSi requested a review from a team October 3, 2023 09:30
@AlekSi AlekSi disabled auto-merge October 4, 2023 10:22
@AlekSi AlekSi merged commit 68ac650 into FerretDB:main Oct 4, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement database Stats
2 participants
@chilagrow @AlekSi