Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TODOs for capped collections #3461

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add TODOs for capped collections #3461

merged 1 commit into from
Oct 6, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 28, 2023 •
edited
Loading

Description

Describe future work.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Sep 28, 2023
@AlekSi AlekSi added this to the Next milestone Sep 28, 2023
@AlekSi AlekSi self-assigned this Sep 28, 2023
@AlekSi AlekSi mentioned this pull request Oct 3, 2023
Merged
9 tasks
@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added conflict PRs that have merge conflicts and removed conflict PRs that have merge conflicts labels Oct 5, 2023
@mergify mergify bot mentioned this pull request Oct 6, 2023
Closed
9 tasks
@AlekSi AlekSi changed the title Add stubs for capped collections Add TODOs for capped collections Oct 6, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Oct 6, 2023
@AlekSi AlekSi marked this pull request as ready for review October 6, 2023 05:43
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners October 6, 2023 05:43
@AlekSi AlekSi enabled auto-merge (squash) October 6, 2023 05:43
@AlekSi AlekSi requested review from a team, noisersup and Fashander October 6, 2023 05:43
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #3461 (109cb4a) into main (e5e2485) will decrease coverage by 0.54%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3461      +/-   ##
==========================================
- Coverage   74.31%   73.78%   -0.54%     
==========================================
  Files         426      426              
  Lines       26858    26875      +17     
==========================================
- Hits        19960    19830     -130     
- Misses       5738     5861     +123     
- Partials     1160     1184      +24
Files Coverage Δ
internal/backends/collection.go 91.66% <100.00%> (+0.41%) ⬆️
internal/backends/sqlite/collection.go 77.77% <100.00%> (-0.93%) ⬇️
internal/handlers/common/find.go 100.00% <ø> (ø)
internal/handlers/pg/msg_serverstatus.go 72.72% <100.00%> (ø)
internal/handlers/sqlite/msg_collstats.go 66.19% <100.00%> (+0.48%) ⬆️
internal/handlers/sqlite/msg_create.go 71.62% <100.00%> (ø)
internal/backends/postgresql/collection.go 14.97% <0.00%> (-0.15%) ⬇️
internal/backends/database.go 94.20% <50.00%> (-5.80%) ⬇️

... and 19 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.94% <70.00%> (-0.60%) ⬇️
hana-1 ?
integration 67.94% <70.00%> (-0.64%) ⬇️
mongodb-1 4.57% <0.00%> (-0.01%) ⬇️
pg-1 39.29% <5.00%> (-0.50%) ⬇️
pg-2 42.36% <5.00%> (-0.57%) ⬇️
pg-3 42.86% <5.00%> (-0.65%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 67.94% <70.00%> (-0.23%) ⬇️
sort-true ?
sqlite-1 38.42% <65.00%> (-0.08%) ⬇️
sqlite-2 41.69% <65.00%> (+0.03%) ⬆️
sqlite-3 42.43% <65.00%> (-0.02%) ⬇️
unit 25.60% <30.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some small detail I found out while playing with capped collection 🤗

internal/backends/database.go Show resolved Hide resolved
internal/backends/database.go Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge October 6, 2023 12:32
@AlekSi AlekSi merged commit c52cfc2 into FerretDB:main Oct 6, 2023
46 of 51 checks passed
@AlekSi AlekSi deleted the capped branch October 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@Fashander Fashander Fashander approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @Fashander