Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak SQLite backend tests #3460

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Tweak SQLite backend tests #3460

merged 3 commits into from
Sep 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 28, 2023

Description

Prevent one kind of tests failure.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 28, 2023
@AlekSi AlekSi added this to the Next milestone Sep 28, 2023
@AlekSi AlekSi self-assigned this Sep 28, 2023
@AlekSi AlekSi marked this pull request as ready for review September 28, 2023 15:38
@AlekSi AlekSi enabled auto-merge (squash) September 28, 2023 15:38
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup September 28, 2023 15:38
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #3460 (796b34a) into main (3572f9b) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3460      +/-   ##
==========================================
- Coverage   74.02%   73.93%   -0.10%     
==========================================
  Files         422      422              
  Lines       26375    26375              
==========================================
- Hits        19525    19500      -25     
- Misses       5704     5730      +26     
+ Partials     1146     1145       -1

see 7 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 69.18% <ø> (-0.14%) ⬇️
hana-1 ?
integration 69.18% <ø> (-0.14%) ⬇️
mongodb-1 4.63% <ø> (ø)
pg-1 40.61% <ø> (-0.04%) ⬇️
pg-2 43.15% <ø> (-0.10%) ⬇️
pg-3 42.90% <ø> (ø)
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 69.18% <ø> (-0.14%) ⬇️
sort-true ?
sqlite-1 39.74% <ø> (+0.02%) ⬆️
sqlite-2 42.37% <ø> (-0.10%) ⬇️
sqlite-3 42.39% <ø> (-0.01%) ⬇️
unit 24.48% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

chilagrow
chilagrow approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi merged commit 1182de2 into FerretDB:main Sep 29, 2023
25 of 28 checks passed
@AlekSi AlekSi deleted the sqlite-schema branch September 29, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow