Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for backends contract #3456

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Add tests for backends contract #3456

merged 8 commits into from
Sep 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 28, 2023 •
edited
Loading

Description

Test that updates are no-op for non-existing databases or collections.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Sep 28, 2023
@AlekSi AlekSi added this to the Next milestone Sep 28, 2023
@AlekSi AlekSi self-assigned this Sep 28, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 28, 2023
@AlekSi AlekSi marked this pull request as ready for review September 28, 2023 16:09
@AlekSi AlekSi requested a review from a team as a code owner September 28, 2023 16:09
@AlekSi AlekSi enabled auto-merge (squash) September 28, 2023 16:09
@AlekSi AlekSi requested review from a team and noisersup September 28, 2023 16:09
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #3456 (cda6ceb) into main (1182de2) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
+ Coverage   73.97%   74.15%   +0.18%     
==========================================
  Files         422      422              
  Lines       26375    26374       -1     
==========================================
+ Hits        19510    19558      +48     
+ Misses       5716     5661      -55     
- Partials     1149     1155       +6
Files Coverage Δ
internal/handlers/sqlite/msg_createindexes.go 89.53% <100.00%> (-0.03%) ⬇️

... and 16 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.15% <100.00%> (-0.09%) ⬇️
hana-1 ?
integration 69.15% <100.00%> (-0.09%) ⬇️
mongodb-1 4.63% <0.00%> (+<0.01%) ⬆️
pg-1 40.58% <0.00%> (-0.03%) ⬇️
pg-2 43.24% <0.00%> (+0.09%) ⬆️
pg-3 42.90% <0.00%> (+<0.01%) ⬆️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ?
postgresql-3 ?
sort-false 69.15% <100.00%> (-0.09%) ⬇️
sqlite-1 39.74% <100.00%> (+0.05%) ⬆️
sqlite-2 42.37% <100.00%> (-0.10%) ⬇️
sqlite-3 42.39% <100.00%> (-0.01%) ⬇️
unit 25.06% <0.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

chilagrow
chilagrow previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🙏

noisersup
noisersup reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from failing test

@AlekSi AlekSi dismissed stale reviews from chilagrow and rumyantseva via cda6ceb September 29, 2023 07:17
@AlekSi AlekSi disabled auto-merge September 29, 2023 07:36
@AlekSi AlekSi merged commit a25c3a7 into FerretDB:main Sep 29, 2023
25 of 28 checks passed
@AlekSi AlekSi deleted the backend-tests branch September 29, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup left review comments

@chilagrow chilagrow chilagrow left review comments

@rumyantseva rumyantseva rumyantseva left review comments

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup