Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused expected failures #3455

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Remove unused expected failures #3455

merged 3 commits into from
Sep 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 28, 2023

Description

Just a small cleanup.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Sep 28, 2023
@AlekSi AlekSi added this to the Next milestone Sep 28, 2023
@AlekSi AlekSi self-assigned this Sep 28, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 28, 2023
@AlekSi AlekSi marked this pull request as ready for review September 28, 2023 10:04
@AlekSi AlekSi requested a review from a team as a code owner September 28, 2023 10:04
@AlekSi AlekSi enabled auto-merge (squash) September 28, 2023 10:04
@AlekSi AlekSi requested review from a team and noisersup September 28, 2023 10:04
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #3455 (4187f40) into main (437aeed) will increase coverage by 1.26%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
+ Coverage   72.69%   73.96%   +1.26%     
==========================================
  Files         422      422              
  Lines       26346    26346              
==========================================
+ Hits        19152    19486     +334     
+ Misses       6031     5712     -319     
+ Partials     1163     1148      -15

see 27 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.26% <ø> (+1.32%) ⬆️
hana-1 ?
integration 69.26% <ø> (+1.32%) ⬆️
mongodb-1 4.64% <ø> (ø)
pg-1 40.66% <ø> (+<0.01%) ⬆️
pg-2 43.29% <ø> (ø)
pg-3 42.95% <ø> (ø)
postgresql-1 ∅ <ø> (∅)
postgresql-2 ?
postgresql-3 ?
sort-false 69.26% <ø> (+1.32%) ⬆️
sqlite-1 39.79% <ø> (+0.06%) ⬆️
sqlite-2 42.42% <ø> (?)
sqlite-3 42.44% <ø> (ø)
unit 24.45% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

noisersup
noisersup approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 5a6881d into FerretDB:main Sep 28, 2023
23 of 27 checks passed
@AlekSi AlekSi deleted the remove-unused branch September 28, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @noisersup