Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $project and $unset to aggregation stages section #3450

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Add $project and $unset to aggregation stages section #3450

merged 12 commits into from
Oct 4, 2023

Conversation

Akhaled19
Copy link
Contributor

Added $project and $unset commands to the Aggregation Stages list and gave them a description.

Closes #3428.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlekSi AlekSi changed the title closes issue #3428 Add $project and $unset to aggregation stages section Sep 28, 2023
@AlekSi AlekSi added this to the Next milestone Sep 28, 2023
@AlekSi AlekSi requested a review from Fashander September 28, 2023 04:34
@AlekSi AlekSi added the documentation Something user-visible is badly or not documented label Sep 28, 2023
@AlekSi AlekSi enabled auto-merge (squash) September 28, 2023 04:34
@AlekSi
Copy link
Member

AlekSi commented Sep 28, 2023

@Akhaled19 please click CLA button in this comment

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Merging #3450 (8c68214) into main (d05546d) will decrease coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
- Coverage   74.03%   73.13%   -0.91%     
==========================================
  Files         424      424              
  Lines       26539    26539              
==========================================
- Hits        19648    19409     -239     
- Misses       5727     5948     +221     
- Partials     1164     1182      +18

see 22 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.80% <ø> (-1.06%) ⬇️
hana-1 ?
integration 67.80% <ø> (-1.06%) ⬇️
mongodb-1 4.60% <ø> (ø)
pg-1 ?
pg-2 43.00% <ø> (-0.01%) ⬇️
pg-3 42.65% <ø> (ø)
postgresql-1 ∅ <ø> (∅)
postgresql-2 ?
postgresql-3 ?
sort-false 67.80% <ø> (-1.06%) ⬇️
sqlite-1 39.49% <ø> (ø)
sqlite-2 42.22% <ø> (ø)
sqlite-3 42.14% <ø> (ø)
unit 25.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Fashander
Fashander reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

We need to leave a new line at the end of every file. See here for information on formatting and building documentation https://github.com/FerretDB/FerretDB/blob/main/CONTRIBUTING.md#contributing-documentation

auto-merge was automatically disabled September 28, 2023 17:40

Head branch was pushed to by a user without write access

Akhaled19 and others added 2 commits September 28, 2023 13:40
@Akhaled19 @Fashander
Update website/docs/aggregation-operations/aggregation-stages.md
d3f7267 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@Akhaled19 @Fashander
Update website/docs/aggregation-operations/aggregation-stages.md
f2fa6db 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@Fashander Fashander enabled auto-merge (squash) September 29, 2023 08:43
@Akhaled19
Copy link
Contributor Author

Akhaled19 commented Sep 29, 2023 •
edited
Loading

Hi @Fashander, I resolved all the comments. Is it ready to be merged?

Fashander
Fashander previously approved these changes Oct 3, 2023
View reviewed changes
AlekSi
AlekSi reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation should be reformatted with task docs-fmt because CI fails: https://github.com/FerretDB/FerretDB/actions/runs/6382671742/job/17321772162?pr=3450

@AlekSi AlekSi requested review from Fashander, AlekSi and a team October 4, 2023 13:59
@Fashander Fashander merged commit f9f5e9a into FerretDB:main Oct 4, 2023
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@Fashander Fashander

@Akhaled19 Akhaled19

Labels
documentation Something user-visible is badly or not documented
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Add $project and $unset to documentation
4 participants
@Akhaled19 @CLAassistant @AlekSi @Fashander