Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra function #3447

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Remove extra function #3447

merged 2 commits into from
Sep 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 27, 2023

Description

Small cleanup.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 27, 2023
@AlekSi AlekSi added this to the Next milestone Sep 27, 2023
@AlekSi AlekSi self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #3447 (8a1f10b) into main (b7a6330) will decrease coverage by 0.40%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3447      +/-   ##
==========================================
- Coverage   75.61%   75.22%   -0.40%     
==========================================
  Files         420      420              
  Lines       26191    26179      -12     
==========================================
- Hits        19805    19692     -113     
- Misses       5268     5353      +85     
- Partials     1118     1134      +16
Files Coverage Δ
internal/bson/document.go 51.73% <100.00%> (+0.34%) ⬆️
internal/handlers/common/filter.go 84.27% <100.00%> (+0.17%) ⬆️
internal/handlers/common/positional_operator.go 83.09% <100.00%> (+3.64%) ⬆️
internal/handlers/common/projection.go 89.00% <100.00%> (+0.45%) ⬆️
internal/util/debug/debug.go 86.20% <100.00%> (+6.20%) ⬆️
internal/bson/bson.go 43.33% <0.00%> (ø)
internal/wire/op_reply.go 39.50% <0.00%> (ø)
internal/wire/op_query.go 33.33% <0.00%> (ø)

... and 18 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 71.77% <60.00%> (-0.45%) ⬇️
hana-1 ?
integration 71.77% <60.00%> (-0.51%) ⬇️
mongodb-1 ?
pg-1 41.72% <30.00%> (-0.43%) ⬇️
pg-2 43.93% <50.00%> (-0.39%) ⬇️
pg-3 41.66% <50.00%> (-0.65%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 41.53% <50.00%> (+0.03%) ⬆️
postgresql-3 39.31% <50.00%> (+0.02%) ⬆️
sort-false 71.77% <60.00%> (-0.28%) ⬇️
sort-true ?
sqlite-1 40.75% <30.00%> (-0.05%) ⬇️
sqlite-2 43.05% <50.00%> (-0.02%) ⬇️
sqlite-3 41.12% <50.00%> (+0.02%) ⬆️
unit 24.48% <10.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review September 27, 2023 16:42
@AlekSi AlekSi requested a review from a team as a code owner September 27, 2023 16:42
@AlekSi AlekSi enabled auto-merge (squash) September 27, 2023 16:42
@AlekSi AlekSi requested review from a team and noisersup September 27, 2023 16:42
rumyantseva
rumyantseva approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AlekSi AlekSi merged commit ff4a3b6 into FerretDB:main Sep 28, 2023
25 of 28 checks passed
@AlekSi AlekSi deleted the minor-cleanup branch September 28, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow