Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark pushdown results based on tested backend #3446

Merged
merged 90 commits into from
Sep 28, 2023
Merged

Mark pushdown results based on tested backend #3446

merged 90 commits into from
Sep 28, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Sep 27, 2023 •
edited
Loading

Description

Closes #3235.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #3446 (6162cae) into main (8788b92) will decrease coverage by 0.18%.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3446      +/-   ##
==========================================
- Coverage   75.43%   75.26%   -0.18%     
==========================================
  Files         421      422       +1     
  Lines       26238    26263      +25     
==========================================
- Hits        19792    19766      -26     
- Misses       5306     5353      +47     
- Partials     1140     1144       +4
Files Coverage Δ
integration/setup/test_helpers.go 100.00% <100.00%> (ø)
integration/shareddata/scalars.go 100.00% <100.00%> (ø)
integration/pushdown.go 61.11% <61.11%> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.91% <76.66%> (-0.19%) ⬇️
hana-1 ?
integration 71.91% <76.66%> (-0.19%) ⬇️
mongodb-1 4.65% <40.00%> (+0.04%) ⬆️
pg-1 41.40% <66.66%> (+0.01%) ⬆️
pg-2 42.38% <66.66%> (+0.01%) ⬆️
pg-3 43.76% <66.66%> (+0.02%) ⬆️
postgresql-1 ∅ <ø> (∅)
postgresql-2 40.04% <66.66%> (+0.01%) ⬆️
postgresql-3 41.50% <60.00%> (+0.01%) ⬆️
sort-false 71.91% <76.66%> (-0.19%) ⬇️
sqlite-1 40.39% <66.66%> (+<0.01%) ⬆️
sqlite-2 41.57% <66.66%> (-0.07%) ⬇️
sqlite-3 43.26% <70.00%> (+0.02%) ⬆️
unit 24.51% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Sep 27, 2023
@noisersup noisersup changed the title Pushdown results 3235 Mark pushdown results based on tested backend Sep 27, 2023
@noisersup noisersup marked this pull request as ready for review September 27, 2023 17:17
@noisersup noisersup requested a review from a team as a code owner September 27, 2023 17:17
@noisersup noisersup requested review from AlekSi, rumyantseva, a team and chilagrow September 27, 2023 17:18
@AlekSi AlekSi added this to the Next milestone Sep 28, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Sep 28, 2023
@AlekSi AlekSi enabled auto-merge (squash) September 28, 2023 09:58
@AlekSi AlekSi merged commit bdffc74 into FerretDB:main Sep 28, 2023
33 of 53 checks passed
@noisersup noisersup deleted the pushdown-results-3235 branch September 28, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement filter pushdown for SQLite
3 participants
@noisersup @AlekSi @chilagrow