Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DeleteAll #3441

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Implement DeleteAll #3441

merged 3 commits into from
Sep 27, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Sep 26, 2023 •
edited
Loading

Description

Closes #3400.

Delete tests passes once InsertAll is merged #3419

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Sep 26, 2023
@chilagrow chilagrow added this to the Next milestone Sep 26, 2023
@chilagrow chilagrow self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #3441 (c57565d) into main (6b5b4f1) will decrease coverage by 5.47%.
The diff coverage is 60.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
- Coverage   75.46%   70.00%   -5.47%     
==========================================
  Files         419      420       +1     
  Lines       26155    26191      +36     
==========================================
- Hits        19737    18334    -1403     
- Misses       5285     6642    +1357     
- Partials     1133     1215      +82
Files Coverage Δ
...ternal/backends/postgresql/metadata/placeholder.go 100.00% <100.00%> (ø)
internal/backends/postgresql/collection.go 64.84% <57.14%> (-3.58%) ⬇️

... and 72 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.07% <60.52%> (-5.95%) ⬇️
hana-1 ?
integration 66.07% <60.52%> (-5.95%) ⬇️
mongodb-1 4.61% <0.00%> (-0.01%) ⬇️
pg-1 ?
pg-2 43.88% <0.00%> (-0.04%) ⬇️
pg-3 41.64% <0.00%> (-0.06%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 41.50% <60.52%> (-0.03%) ⬇️
postgresql-3 39.29% <60.52%> (-0.01%) ⬇️
sort-false 66.07% <60.52%> (-5.95%) ⬇️
sqlite-1 ?
sqlite-2 42.97% <0.00%> (-0.11%) ⬇️
sqlite-3 41.10% <0.00%> (-0.06%) ⬇️
unit 24.48% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review September 27, 2023 04:05
@chilagrow chilagrow requested a review from AlekSi as a code owner September 27, 2023 04:05
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup September 27, 2023 04:05
AlekSi
AlekSi previously approved these changes Sep 27, 2023
View reviewed changes
@AlekSi AlekSi enabled auto-merge (squash) September 27, 2023 08:05
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Sep 27, 2023
@AlekSi
Merge branch 'main' into pr/chilagrow/3441
c57565d 
# Conflicts:
#	internal/backends/postgresql/collection.go
@AlekSi AlekSi requested review from AlekSi and a team September 27, 2023 16:47
@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 27, 2023
rumyantseva
rumyantseva approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable to me!

@AlekSi AlekSi merged commit b7a6330 into FerretDB:main Sep 27, 2023
32 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement DeleteAll
3 participants
@chilagrow @AlekSi @rumyantseva