Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RenameCollection #3440

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Implement RenameCollection #3440

merged 3 commits into from
Sep 26, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 26, 2023

Description

To trigger issues similar to #3409 earlier.

Closes #3393.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Sep 26, 2023
@AlekSi AlekSi added this to the Next milestone Sep 26, 2023
@AlekSi AlekSi self-assigned this Sep 26, 2023
@AlekSi AlekSi enabled auto-merge (squash) September 26, 2023 10:26
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup September 26, 2023 10:26
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #3440 (acee067) into main (606e326) will increase coverage by 0.48%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3440      +/-   ##
==========================================
+ Coverage   74.18%   74.67%   +0.48%     
==========================================
  Files         418      418              
  Lines       25949    25974      +25     
==========================================
+ Hits        19251    19396     +145     
+ Misses       5555     5433     -122     
- Partials     1143     1145       +2     
Files Coverage Δ
internal/backends/postgresql/metadata/pool/pool.go 68.96% <100.00%> (+3.44%) ⬆️
internal/backends/sqlite/database.go 76.66% <100.00%> (-0.26%) ⬇️
internal/backends/sqlite/metadata/pool/pool.go 63.30% <100.00%> (ø)
internal/backends/postgresql/database.go 39.58% <0.00%> (+39.58%) ⬆️

... and 18 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.80% <18.18%> (+1.15%) ⬆️
hana-1 ?
integration 70.80% <18.18%> (+1.15%) ⬆️
mongodb-1 4.65% <0.00%> (-0.01%) ⬇️
pg-1 42.76% <0.00%> (-0.09%) ⬇️
pg-2 42.53% <0.00%> (-0.05%) ⬇️
pg-3 42.98% <0.00%> (-0.01%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 27.27% <3.03%> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 70.80% <18.18%> (+1.15%) ⬆️
sqlite-1 41.73% <12.12%> (-0.05%) ⬇️
sqlite-2 41.19% <9.09%> (-0.05%) ⬇️
sqlite-3 42.08% <15.15%> (+0.05%) ⬆️
unit 24.47% <12.12%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AlekSi AlekSi disabled auto-merge September 26, 2023 13:05
@AlekSi AlekSi merged commit 0703337 into FerretDB:main Sep 26, 2023
26 of 30 checks passed
@AlekSi AlekSi deleted the rename-collection branch September 26, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement RenameCollection
2 participants