Fix fluky TestRenameCollectionCompat tests
#3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3438 +/- ##
==========================================
- Coverage 75.39% 74.72% -0.68%
==========================================
Files 420 420
Lines 26179 26179
==========================================
- Hits 19738 19562 -176
- Misses 5308 5471 +163
- Partials 1133 1146 +13 see 23 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
reviewed
Sep 26, 2023
rumyantseva
previously approved these changes
Sep 26, 2023
AlekSi
reviewed
Sep 26, 2023
chilagrow
changed the title
RenameCollection testsTestRenameCollectionCompat tests
AlekSi
approved these changes
Sep 27, 2023
noisersup
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3409.
Test sometimes fails because
TestRenameCollectionCompatcontainsValidtest case which actually rename collection. After that has executed, collection no longer exists. So I've separated valid case to another compat test.Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.