Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store indexes metadata #3434

Merged
merged 51 commits into from
Oct 5, 2023
Merged

Store indexes metadata #3434

merged 51 commits into from
Oct 5, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Sep 26, 2023 •
edited
Loading

Description

Closes #3375.

In addition to unit tests, I also ran various integration tests locally, e.g.

task test-integration-postgresql SHARD_INDEX=0 SHARD_TOTAL=0 TEST_RUN="TestCollectionName"

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Sep 26, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Sep 26, 2023
@rumyantseva rumyantseva added this to the Next milestone Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #3434 (bc1800a) into main (3e69f59) will decrease coverage by 0.34%.
The diff coverage is 71.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3434      +/-   ##
==========================================
- Coverage   74.11%   73.78%   -0.34%     
==========================================
  Files         424      426       +2     
  Lines       26553    26856     +303     
==========================================
+ Hits        19681    19815     +134     
- Misses       5717     5857     +140     
- Partials     1155     1184      +29
Files Coverage Δ
internal/backends/sqlite/metadata/metadata.go 100.00% <ø> (+27.27%) ⬆️
internal/backends/sqlite/metadata/registry.go 70.17% <100.00%> (ø)
internal/util/state/state.go 100.00% <100.00%> (ø)
internal/backends/postgresql/metadata/indexes.go 95.83% <95.83%> (ø)
internal/backends/sqlite/metadata/settings.go 65.71% <65.71%> (ø)
internal/backends/postgresql/metadata/metadata.go 56.92% <48.07%> (-43.08%) ⬇️
internal/backends/postgresql/metadata/registry.go 63.83% <69.23%> (-2.98%) ⬇️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.93% <5.13%> (-0.96%) ⬇️
hana-1 ?
integration 67.93% <5.13%> (-0.96%) ⬇️
mongodb-1 4.57% <0.00%> (-0.06%) ⬇️
pg-1 39.92% <0.27%> (-0.47%) ⬇️
pg-2 42.49% <0.27%> (-0.40%) ⬇️
pg-3 42.14% <0.27%> (-0.49%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 67.93% <5.13%> (-0.96%) ⬇️
sqlite-1 39.04% <5.13%> (-0.48%) ⬇️
sqlite-2 41.72% <4.59%> (-0.39%) ⬇️
sqlite-3 41.64% <4.59%> (-0.49%) ⬇️
unit 25.58% <71.35%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Sep 27, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 28, 2023
@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Oct 4, 2023
@AlekSi
Copy link
Member

AlekSi commented Oct 4, 2023

@rumyantseva is it ready for review?

@rumyantseva
Copy link
Contributor Author

@AlekSi almost! a couple of last checks, and I'll re-request review

AlekSi
AlekSi reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-request when ready

chilagrow
chilagrow previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

internal/backends/postgresql/metadata/registry.go Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Oct 5, 2023
AlekSi
AlekSi reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a merge conflict

@mergify mergify bot removed the conflict PRs that have merge conflicts label Oct 5, 2023
noisersup
noisersup approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit f1a1b5b into FerretDB:main Oct 5, 2023
26 of 29 checks passed
@rumyantseva rumyantseva deleted the issue-3375-pg-indexes-mentadata branch October 5, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Store index metadata
4 participants
@rumyantseva @AlekSi @chilagrow @noisersup