Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SAP HANA backend stub #3433

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Add SAP HANA backend stub #3433

merged 4 commits into from
Sep 26, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 26, 2023

Description

Makes integration tests fail faster without panic.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Fix fluky test
5fb8981
@AlekSi
Add SAP HANA backend stub
1fd811c 
Makes integration tests fail faster without panic.
@AlekSi AlekSi added code/chore Code maintenance improvements trust PRs that can access Actions secrets labels Sep 26, 2023
@AlekSi AlekSi added this to the Next milestone Sep 26, 2023
@AlekSi AlekSi self-assigned this Sep 26, 2023
@AlekSi AlekSi requested a review from a team as a code owner September 26, 2023 06:57
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup September 26, 2023 06:57
@AlekSi AlekSi enabled auto-merge (squash) September 26, 2023 06:58
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #3433 (97a09a3) into main (6ef88d0) will decrease coverage by 0.09%.
The diff coverage is 36.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3433      +/-   ##
==========================================
- Coverage   74.23%   74.15%   -0.09%     
==========================================
  Files         415      418       +3     
  Lines       25885    25949      +64     
==========================================
+ Hits        19217    19243      +26     
- Misses       5524     5561      +37     
- Partials     1144     1145       +1
Files Coverage Δ
integration/setup/listener.go 78.91% <100.00%> (+2.83%) ⬆️
integration/setup/setup.go 77.52% <ø> (ø)
internal/backends/postgresql/backend.go 0.00% <ø> (ø)
internal/backends/sqlite/backend.go 68.75% <ø> (+2.08%) ⬆️
internal/handlers/registry/hana.go 71.42% <100.00%> (+63.73%) ⬆️
internal/handlers/registry/pg.go 46.66% <ø> (+2.91%) ⬆️
internal/handlers/registry/registry.go 50.00% <ø> (ø)
internal/handlers/sqlite/sqlite.go 62.22% <100.00%> (+13.50%) ⬆️
internal/backends/hana/database.go 0.00% <0.00%> (ø)
internal/backends/hana/backend.go 11.11% <11.11%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

Flag Coverage Δ
filter-true 69.62% <36.11%> (-0.07%) ⬇️
hana-1 2.98% <36.11%> (?)
integration 69.62% <36.11%> (-0.07%) ⬇️
mongodb-1 4.65% <0.00%> (-0.02%) ⬇️
pg-1 42.84% <2.77%> (-0.11%) ⬇️
pg-2 42.57% <2.77%> (-0.11%) ⬇️
pg-3 43.12% <2.77%> (-0.01%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 ∅ <ø> (∅)
postgresql-3 ∅ <ø> (∅)
sort-false 69.62% <36.11%> (-0.07%) ⬇️
sqlite-1 41.73% <2.77%> (-0.15%) ⬇️
sqlite-2 41.23% <2.77%> (-0.10%) ⬇️
sqlite-3 42.12% <2.77%> (-0.11%) ⬇️
unit 24.49% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as draft September 26, 2023 07:05
auto-merge was automatically disabled September 26, 2023 07:05

Pull request was converted to draft

@AlekSi AlekSi added not ready Issues that are not ready to be worked on; PRs that should skip CI do not merge PRs that should not be merged labels Sep 26, 2023
@AlekSi AlekSi removed not ready Issues that are not ready to be worked on; PRs that should skip CI do not merge PRs that should not be merged labels Sep 26, 2023
@AlekSi AlekSi marked this pull request as ready for review September 26, 2023 09:25
@AlekSi AlekSi enabled auto-merge (squash) September 26, 2023 09:25
@AlekSi AlekSi requested review from a team and removed request for a team September 26, 2023 09:25
chilagrow
chilagrow approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi disabled auto-merge September 26, 2023 10:07
@AlekSi AlekSi merged commit 606e326 into FerretDB:main Sep 26, 2023
48 of 70 checks passed
@AlekSi AlekSi deleted the hana-stub branch September 26, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow