Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement InsertAll #3419

Merged
merged 25 commits into from
Sep 27, 2023
Merged

Implement InsertAll #3419

merged 25 commits into from
Sep 27, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Sep 25, 2023 •
edited
Loading

Description

Closes #3395.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Sep 25, 2023
@chilagrow chilagrow added this to the Next milestone Sep 25, 2023
@chilagrow chilagrow self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #3419 (3c0ed1a) into main (7149641) will increase coverage by 0.30%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
+ Coverage   75.08%   75.38%   +0.30%     
==========================================
  Files         418      419       +1     
  Lines       26108    26155      +47     
==========================================
+ Hits        19603    19717     +114     
+ Misses       5370     5308      -62     
+ Partials     1135     1130       -5
Files Coverage Δ
...l/backends/postgresql/metadata/pool/transaction.go 100.00% <100.00%> (ø)
internal/backends/postgresql/metadata/registry.go 66.51% <100.00%> (+2.03%) ⬆️
internal/backends/postgresql/collection.go 68.42% <47.05%> (+23.25%) ⬆️

... and 11 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.93% <54.16%> (+0.73%) ⬆️
hana-1 ?
integration 71.93% <54.16%> (+0.73%) ⬆️
mongodb-1 4.62% <0.00%> (-0.01%) ⬇️
pg-1 41.76% <0.00%> (+0.02%) ⬆️
pg-2 43.96% <0.00%> (-0.09%) ⬇️
pg-3 41.70% <0.00%> (-0.08%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 41.47% <54.16%> (+14.03%) ⬆️
postgresql-3 39.25% <54.16%> (+12.33%) ⬆️
sort-false 71.93% <54.16%> (+0.73%) ⬆️
sqlite-1 40.81% <0.00%> (+0.01%) ⬆️
sqlite-2 43.08% <0.00%> (-0.08%) ⬇️
sqlite-3 41.15% <0.00%> (-0.08%) ⬇️
unit 24.49% <56.25%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review September 25, 2023 09:57
@chilagrow chilagrow requested a review from AlekSi as a code owner September 25, 2023 09:57
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup September 25, 2023 09:57
@chilagrow chilagrow enabled auto-merge (squash) September 25, 2023 09:57
AlekSi
AlekSi previously approved these changes Sep 25, 2023
View reviewed changes
internal/backends/postgresql/metadata/pool/transaction.go Outdated Show resolved Hide resolved
noisersup
noisersup previously approved these changes Sep 25, 2023
View reviewed changes
rumyantseva
rumyantseva previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow dismissed stale reviews from noisersup, rumyantseva, and AlekSi via 9bd3b94 September 26, 2023 06:27
rumyantseva
rumyantseva previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow mentioned this pull request Sep 27, 2023
Merged
9 tasks
AlekSi
AlekSi reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a data race: https://github.com/FerretDB/FerretDB/actions/runs/6320745819/job/17163700348?pr=3419

@chilagrow chilagrow requested a review from AlekSi September 27, 2023 08:21
@chilagrow chilagrow mentioned this pull request Sep 27, 2023
Merged
9 tasks
rumyantseva
rumyantseva approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chilagrow chilagrow merged commit 6b5b4f1 into FerretDB:main Sep 27, 2023
25 of 28 checks passed
@AlekSi AlekSi changed the title Implement InsertAll for PostgreSQL Implement Collection.InsertAll Oct 9, 2023
@AlekSi AlekSi changed the title Implement Collection.InsertAll Implement InsertAll Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement InsertAll
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup