Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSS feed issue with images #3417

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Fix RSS feed issue with images #3417

merged 7 commits into from
Sep 28, 2023

Conversation

Fashander
Copy link
Member

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Sep 22, 2023
@Fashander Fashander added this to the Next milestone Sep 22, 2023
@Fashander Fashander self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #3417 (b5f80ac) into main (b7a6330) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3417      +/-   ##
==========================================
- Coverage   75.43%   75.39%   -0.04%     
==========================================
  Files         420      420              
  Lines       26191    26191              
==========================================
- Hits        19756    19746      -10     
- Misses       5302     5310       +8     
- Partials     1133     1135       +2     

see 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 71.94% <ø> (-0.03%) ⬇️
hana-1 2.95% <ø> (ø)
integration 71.94% <ø> (-0.03%) ⬇️
mongodb-1 4.61% <ø> (ø)
pg-1 41.60% <ø> (-0.11%) ⬇️
pg-2 43.86% <ø> (-0.04%) ⬇️
pg-3 41.64% <ø> (ø)
postgresql-1 ∅ <ø> (∅)
postgresql-2 41.50% <ø> (+0.03%) ⬆️
postgresql-3 39.29% <ø> (ø)
sort-false 71.94% <ø> (-0.03%) ⬇️
sqlite-1 40.75% <ø> (+0.08%) ⬆️
sqlite-2 43.02% <ø> (ø)
sqlite-3 41.10% <ø> (ø)
unit 24.48% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ptrfarkas
ptrfarkas previously approved these changes Sep 22, 2023
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Sep 22, 2023
@AlekSi AlekSi enabled auto-merge (squash) September 22, 2023 12:12
@AlekSi AlekSi changed the title Fix rss feed issue with images Fix RSS feed issue with images Sep 22, 2023
@AlekSi AlekSi added blog/engineering Engineering blog posts and removed documentation Something user-visible is badly or not documented labels Sep 22, 2023
@mergify mergify bot requested review from chilagrow, noisersup, rumyantseva and a team September 22, 2023 12:12
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2023

Engineering blog posts should be reviewed by other engineers and @Fashander.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't understand what this fixes because my RSS readers works just fine ¯_(ツ)_/¯

website/docusaurus.config-blog.js Outdated Show resolved Hide resolved
website/docusaurus.config-blog.js Outdated Show resolved Hide resolved
website/docusaurus.config-blog.js Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team September 22, 2023 13:28
@Fashander
Copy link
Member Author

@AlekSi As it is now, we're not able to get blog-images included in the rss feeds. For some sites like Feedly, they seem to just fine, and on a lot of others they don't.

@AlekSi AlekSi modified the milestones: v1.11.0, Next Sep 25, 2023
@mergify mergify bot requested a review from a team September 25, 2023 15:37
@AlekSi AlekSi self-requested a review September 26, 2023 15:54
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 27, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 27, 2023
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot requested a review from a team September 27, 2023 12:50
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge September 28, 2023 12:22
@AlekSi AlekSi merged commit 4db6de2 into FerretDB:main Sep 28, 2023
24 of 30 checks passed
@mergify mergify bot requested a review from a team September 28, 2023 12:22
@Fashander Fashander deleted the update-feed branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog/engineering Engineering blog posts trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants