Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TODOs #3412

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add TODOs #3412

merged 1 commit into from
Sep 22, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 22, 2023

Description

TODO

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 22, 2023
@AlekSi AlekSi added this to the Next milestone Sep 22, 2023
@AlekSi AlekSi self-assigned this Sep 22, 2023
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup September 22, 2023 04:59
@AlekSi AlekSi enabled auto-merge (squash) September 22, 2023 04:59
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #3412 (c48a09c) into main (4e6b869) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3412      +/-   ##
==========================================
- Coverage   74.68%   74.59%   -0.10%     
==========================================
  Files         414      414              
  Lines       25747    25766      +19     
==========================================
- Hits        19230    19219      -11     
- Misses       5375     5403      +28     
- Partials     1142     1144       +2
Files Changed Coverage
internal/backends/postgresql/backend.go 0.00%
internal/backends/postgresql/collection.go 0.00%
internal/backends/postgresql/database.go 0.00%
internal/backends/postgresql/metadata/metadata.go ø
internal/backends/postgresql/metadata/registry.go 0.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 70.01% <0.00%> (-0.10%) ⬇️
mongodb-1 4.69% <0.00%> (-0.01%) ⬇️
pg-1 43.14% <0.00%> (-0.04%) ⬇️
pg-2 42.88% <0.00%> (-0.04%) ⬇️
pg-3 43.42% <0.00%> (-0.04%) ⬇️
pushdown-false 55.44% <0.00%> (-0.05%) ⬇️
pushdown-true 70.01% <0.00%> (-0.06%) ⬇️
sqlite-1 42.07% <0.00%> (-0.04%) ⬇️
sqlite-2 41.54% <0.00%> (-0.03%) ⬇️
sqlite-3 42.43% <0.00%> (-0.08%) ⬇️
unit 24.68% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlekSi AlekSi disabled auto-merge September 22, 2023 05:21
@AlekSi AlekSi merged commit 1813a6b into FerretDB:main Sep 22, 2023
@AlekSi AlekSi deleted the todos branch September 22, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow