Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run new PostgreSQL backend tests #3407

Merged
merged 19 commits into from
Sep 22, 2023
Merged

Run new PostgreSQL backend tests #3407

merged 19 commits into from
Sep 22, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 21, 2023 •
edited
Loading

Description

Closes #3126.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Sep 21, 2023
@AlekSi AlekSi added this to the Next milestone Sep 21, 2023
@AlekSi AlekSi self-assigned this Sep 21, 2023
@AlekSi AlekSi changed the title Add target to run new PostgreSQL backend tests Run new PostgreSQL backend tests Sep 21, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 21, 2023
@AlekSi AlekSi marked this pull request as ready for review September 21, 2023 13:41
@AlekSi AlekSi requested a review from a team as a code owner September 21, 2023 13:41
@AlekSi AlekSi enabled auto-merge (squash) September 21, 2023 13:41
@AlekSi AlekSi requested review from a team and noisersup September 21, 2023 13:41
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #3407 (08a7792) into main (4e6b869) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3407      +/-   ##
==========================================
- Coverage   74.68%   74.63%   -0.06%     
==========================================
  Files         414      414              
  Lines       25747    25747              
==========================================
- Hits        19230    19215      -15     
- Misses       5375     5387      +12     
- Partials     1142     1145       +3
Files Changed Coverage
internal/backends/backend.go ø
internal/backends/collection.go ø
internal/backends/database.go ø
internal/handlers/sqlite/sqlite.go 0.00%
Flag Coverage Δ
filter-true 70.05% <0.00%> (?)
hana-1 ?
hana-2 ?
hana-3 ?
integration 70.05% <0.00%> (-0.06%) ⬇️
mongodb-1 4.69% <0.00%> (ø)
pg-1 43.14% <0.00%> (-0.04%) ⬇️
pg-2 42.91% <0.00%> (ø)
pg-3 43.35% <0.00%> (-0.11%) ⬇️
postgresql-1 ∅ <ø> (?)
postgresql-2 ∅ <ø> (?)
postgresql-3 ∅ <ø> (?)
pushdown-false ?
pushdown-true ?
sort-false 70.05% <0.00%> (?)
sqlite-1 42.10% <0.00%> (-0.01%) ⬇️
sqlite-2 41.56% <0.00%> (-0.01%) ⬇️
sqlite-3 42.37% <0.00%> (-0.14%) ⬇️
unit 24.73% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

.github/workflows/go-cron.yml Show resolved Hide resolved
.github/workflows/go.yml Outdated Show resolved Hide resolved
@AlekSi AlekSi requested review from chilagrow and a team September 22, 2023 04:25
chilagrow
chilagrow approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi disabled auto-merge September 22, 2023 05:22
@AlekSi AlekSi merged commit d976d8c into FerretDB:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Run scheduled CI on combinations of -disable-filter-pushdown and -enable-sort-pushdown flags
2 participants
@AlekSi @chilagrow