Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce valid types usage #3384

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Enforce valid types usage #3384

merged 8 commits into from
Sep 21, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 20, 2023 •
edited
Loading

Description

Check that passed values have valid types. Fix invalid tests.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #3384 (d722e00) into main (05747ae) will increase coverage by 29.64%.
The diff coverage is 94.04%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3384       +/-   ##
===========================================
+ Coverage   43.93%   73.58%   +29.64%     
===========================================
  Files         408      414        +6     
  Lines       25014    25356      +342     
===========================================
+ Hits        10989    18657     +7668     
+ Misses      13082     5598     -7484     
- Partials      943     1101      +158
Files Changed Coverage
internal/types/types.go 84.61%
internal/types/format.go 88.46%
internal/types/array.go 100.00%
internal/types/compare.go 100.00%
internal/types/compare_order.go 100.00%
internal/types/document.go 100.00%
internal/types/document_validation.go 100.00%
internal/types/identical.go 100.00%
internal/types/path.go 100.00%
internal/util/testutil/equal.go 100.00%
... and 1 more
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 70.51% <85.71%> (+26.57%) ⬆️
mongodb-1 4.76% <26.19%> (?)
pg-2 43.58% <84.52%> (?)
pg-3 44.13% <80.95%> (+0.20%) ⬆️
pushdown-false 56.40% <85.71%> (?)
pushdown-true 70.45% <85.71%> (+26.52%) ⬆️
sqlite-1 42.76% <84.52%> (?)
sqlite-2 42.21% <84.52%> (?)
sqlite-3 43.08% <80.95%> (?)
unit 23.41% <72.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Assert type Enforce valid types usage Sep 20, 2023
@AlekSi AlekSi added this to the Next milestone Sep 20, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 20, 2023
@AlekSi AlekSi marked this pull request as ready for review September 20, 2023 12:21
@AlekSi AlekSi requested a review from a team as a code owner September 20, 2023 12:21
@AlekSi AlekSi enabled auto-merge (squash) September 20, 2023 12:21
@AlekSi AlekSi requested review from a team and noisersup September 20, 2023 12:21
chilagrow
chilagrow approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

rumyantseva
rumyantseva approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 33cdbc4 into FerretDB:main Sep 21, 2023
@AlekSi AlekSi deleted the assert-type branch September 21, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow