Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validation for createIndexes and dropIndexes commands for SQLite #3373

Merged
merged 30 commits into from
Sep 27, 2023
Merged

Implement validation for createIndexes and dropIndexes commands for SQLite #3373

merged 30 commits into from
Sep 27, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Sep 18, 2023 •
edited
Loading

Description

Closes #3320.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/enhancement Some user-visible feature could work better label Sep 18, 2023
@rumyantseva rumyantseva added this to the Next milestone Sep 18, 2023
@rumyantseva rumyantseva self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #3373 (74834da) into main (01bbf29) will decrease coverage by 1.25%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3373      +/-   ##
==========================================
- Coverage   75.09%   73.84%   -1.25%     
==========================================
  Files         418      418              
  Lines       25974    26108     +134     
==========================================
- Hits        19504    19279     -225     
- Misses       5349     5666     +317     
- Partials     1121     1163      +42
Files Coverage Δ
integration/setup/test_helpers.go 100.00% <100.00%> (ø)
internal/backends/collection.go 100.00% <ø> (ø)
internal/backends/sqlite/metadata/registry.go 70.17% <100.00%> (-0.57%) ⬇️
internal/handlers/sqlite/msg_listindexes.go 69.01% <100.00%> (ø)
internal/handlers/pg/msg_createindexes.go 82.77% <0.00%> (-2.32%) ⬇️
internal/handlers/sqlite/msg_createindexes.go 89.56% <98.26%> (+3.00%) ⬆️
internal/handlers/sqlite/msg_dropindexes.go 90.20% <94.59%> (+0.37%) ⬆️

... and 33 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 69.80% <96.96%> (-1.45%) ⬇️
hana-1 ?
integration 69.80% <96.96%> (-1.49%) ⬇️
mongodb-1 4.62% <0.00%> (-0.03%) ⬇️
pg-1 ?
pg-2 44.02% <6.06%> (+0.90%) ⬆️
pg-3 41.77% <0.00%> (-1.79%) ⬇️
postgresql-1 ∅ <ø> (∅)
postgresql-2 27.40% <58.78%> (+0.13%) ⬆️
postgresql-3 26.87% <39.39%> (∅)
sort-false 69.80% <96.96%> (-1.23%) ⬇️
sort-true ?
sqlite-1 40.76% <66.06%> (-1.07%) ⬇️
sqlite-2 43.16% <65.45%> (+1.96%) ⬆️
sqlite-3 41.23% <53.93%> (-0.90%) ⬇️
unit 24.32% <0.64%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi modified the milestones: v1.11.0, Next Sep 25, 2023
@rumyantseva rumyantseva marked this pull request as ready for review September 25, 2023 21:16
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners September 25, 2023 21:16
@rumyantseva rumyantseva enabled auto-merge (squash) September 25, 2023 21:16
@rumyantseva rumyantseva requested review from a team and noisersup September 25, 2023 21:16
chilagrow
chilagrow reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comment 🤗 great work!

internal/handlers/sqlite/msg_createindexes.go Show resolved Hide resolved
internal/handlers/sqlite/msg_createindexes.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_createindexes.go Show resolved Hide resolved
internal/handlers/sqlite/msg_createindexes.go Show resolved Hide resolved
internal/handlers/sqlite/msg_dropindexes.go Show resolved Hide resolved
internal/handlers/sqlite/msg_dropindexes.go Show resolved Hide resolved
chilagrow
chilagrow previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

AlekSi
AlekSi reviewed Sep 26, 2023
View reviewed changes
internal/backends/collection.go Outdated Show resolved Hide resolved
integration/indexes_command_compat_test.go Show resolved Hide resolved
integration/indexes_command_compat_test.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_createindexes.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested a review from AlekSi September 26, 2023 14:57
chilagrow
chilagrow approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rumyantseva rumyantseva merged commit 7149641 into FerretDB:main Sep 27, 2023
24 of 28 checks passed
@rumyantseva rumyantseva deleted the issue-3320-validation branch September 27, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.12.1
Development

Successfully merging this pull request may close these issues.

Implement validation for createIndexes and dropIndexes commands
3 participants
@rumyantseva @AlekSi @chilagrow