Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated Jaeger exporter #3368

Merged
merged 25 commits into from
Sep 18, 2023
Merged

Replace deprecated Jaeger exporter #3368

merged 25 commits into from
Sep 18, 2023

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Sep 15, 2023 •
edited by AlekSi
Loading

Description

Closes #3341.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

adetunjii and others added 23 commits May 1, 2023 20:57
@adetunjii
verify message checksum
9861d72
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
a538e85
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
6731573
@adetunjii
fix: removed todo tag for closed issue
9b978c3
@adetunjii
fix: removed todo tags for closed issues
6cc8692
@adetunjii
fix: removed todo tags for closed issues
898adb9
@adetunjii
fix: linting error
e93b955
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
3dd46a6
@AlekSi
Merge branch 'main' into main
d43517d
@adetunjii
Merge branch 'FerretDB:main' into main
05d82b9
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
e602653
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
7c91cae
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
d36c20c
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
a820300
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
83347a3
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
a547e22
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
8979d8a
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
47374f9
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
f642fc5
@adetunjii
Merge branches 'main' and 'main' of https://github.com/adetunjii/Ferr…
610afb7 
…etDB
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
57ffa5a
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB into fix…
b06c6dc 
…/otlp-exporter
@adetunjii
fix: remove deprecated jaeger exporter
e0ba452
@adetunjii adetunjii requested review from AlekSi and a team as code owners September 15, 2023 10:08
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #3368 (b5f52b8) into main (58772a7) will decrease coverage by 1.28%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3368      +/-   ##
==========================================
- Coverage   74.10%   72.82%   -1.28%     
==========================================
  Files         413      413              
  Lines       25317    25317              
==========================================
- Hits        18760    18437     -323     
- Misses       5468     5757     +289     
- Partials     1089     1123      +34
Files Changed Coverage
integration/setup/startup.go 87.50%
Flag Coverage Δ
integration 69.82% <87.50%> (-1.33%) ⬇️
mongodb-1 4.72% <87.50%> (ø)
pg-1 43.81% <87.50%> (ø)
pg-2 43.54% <87.50%> (ø)
pg-3 43.99% <87.50%> (ø)
sqlite-1 42.60% <87.50%> (-0.06%) ⬇️
sqlite-2 42.11% <87.50%> (ø)
sqlite-3 ?
unit 23.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 15, 2023
@AlekSi AlekSi added this to the Next milestone Sep 15, 2023
AlekSi
AlekSi reviewed Sep 15, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
rumyantseva
rumyantseva approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried everything locally, and the changes look good to me!
Thanks a lot for contributing!

@rumyantseva rumyantseva requested a review from AlekSi September 17, 2023 21:28
@rumyantseva rumyantseva enabled auto-merge (squash) September 17, 2023 21:28
@AlekSi
Copy link
Member

AlekSi commented Sep 18, 2023

Thank you!

@rumyantseva rumyantseva merged commit 1cdf743 into FerretDB:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

@adetunjii adetunjii

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Replace deprecated go.opentelemetry.io/otel/exporters/jaeger
3 participants
@adetunjii @AlekSi @rumyantseva