Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata updates for dropIndexes #3358

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Fix metadata updates for dropIndexes #3358

merged 8 commits into from
Sep 18, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Sep 14, 2023 •
edited
Loading

Description

Closes #3328.
Closes #3366.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Sep 14, 2023
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Sep 14, 2023
@rumyantseva rumyantseva added this to the Next milestone Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #3358 (1d695f7) into main (1cdf743) will increase coverage by 0.14%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3358      +/-   ##
==========================================
+ Coverage   74.03%   74.18%   +0.14%     
==========================================
  Files         413      413              
  Lines       25317    25321       +4     
==========================================
+ Hits        18744    18784      +40     
+ Misses       5481     5445      -36     
  Partials     1092     1092
Files Changed Coverage
internal/backends/sqlite/metadata/registry.go 25.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 71.13% <25.00%> (+0.06%) ⬆️
mongodb-1 4.72% <0.00%> (-0.01%) ⬇️
pg-1 43.80% <0.00%> (-0.01%) ⬇️
pg-2 43.53% <0.00%> (-0.01%) ⬇️
pg-3 44.08% <0.00%> (+0.09%) ⬆️
sqlite-1 42.65% <0.00%> (+0.03%) ⬆️
sqlite-2 42.10% <0.00%> (-0.01%) ⬇️
sqlite-3 43.05% <25.00%> (+0.04%) ⬆️
unit 23.26% <25.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup September 14, 2023 16:26
@rumyantseva rumyantseva marked this pull request as ready for review September 14, 2023 16:27
@rumyantseva rumyantseva requested a review from AlekSi as a code owner September 14, 2023 16:27
@rumyantseva rumyantseva enabled auto-merge (squash) September 14, 2023 16:27
chilagrow
chilagrow previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

internal/backends/sqlite/metadata/registry_test.go Show resolved Hide resolved
@rumyantseva rumyantseva mentioned this pull request Sep 15, 2023
Closed
9 tasks
chilagrow
chilagrow approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix as well! 🤗

@AlekSi AlekSi added code/bug Some user-visible feature works incorrectly and removed code/chore Code maintenance improvements labels Sep 18, 2023
@AlekSi AlekSi changed the title Write unit tests for SQLite createIndexes and dropIndexes implementation Fix metadata updates for dropIndexes Sep 18, 2023
@AlekSi AlekSi disabled auto-merge September 18, 2023 09:06
@AlekSi AlekSi enabled auto-merge (squash) September 18, 2023 09:07
@AlekSi AlekSi merged commit 9f8f895 into FerretDB:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
3 participants
@rumyantseva @AlekSi @chilagrow