Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store PostgreSQL metadata #3356

Merged
merged 52 commits into from
Sep 21, 2023
Merged

Store PostgreSQL metadata #3356

merged 52 commits into from
Sep 21, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Sep 14, 2023 •
edited
Loading

Description

Closes #3335.

There is no integration test, because pg still uses handlers/pg/pgdb implementation. So unit tests added are the ones covers the logic.

Indexes will be added in #3375

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Sep 14, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Sep 14, 2023
@chilagrow chilagrow added this to the Next milestone Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #3356 (897daa4) into main (02ae206) will decrease coverage by 0.57%.
The diff coverage is 67.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3356      +/-   ##
==========================================
- Coverage   74.23%   73.66%   -0.57%     
==========================================
  Files         414      414              
  Lines       25356    25747     +391     
==========================================
+ Hits        18823    18967     +144     
- Misses       5445     5604     +159     
- Partials     1088     1176      +88
Files Changed Coverage
internal/backends/postgresql/metadata/registry.go 66.14%
internal/backends/postgresql/metadata/metadata.go 100.00%
...ternal/backends/postgresql/metadata/pool/opendb.go 100.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 68.92% <0.00%> (-2.26%) ⬇️
mongodb-1 4.69% <0.00%> (-0.08%) ⬇️
pg-1 43.14% <0.00%> (-0.68%) ⬇️
pg-2 42.91% <0.00%> (-0.68%) ⬇️
pg-3 ?
pushdown-false 55.48% <0.00%> (-0.84%) ⬇️
pushdown-true 68.91% <0.00%> (-2.26%) ⬇️
sqlite-1 42.15% <0.00%> (-0.67%) ⬇️
sqlite-2 41.56% <0.00%> (-0.65%) ⬇️
sqlite-3 42.46% <0.00%> (-0.76%) ⬇️
unit 24.69% <67.58%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi self-assigned this Sep 17, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 18, 2023
@AlekSi AlekSi requested review from a team September 20, 2023 08:28
@AlekSi AlekSi self-requested a review September 20, 2023 17:30
@chilagrow chilagrow requested a review from AlekSi September 21, 2023 10:16
rumyantseva
rumyantseva previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, I don't have further questions.

When we start using the metadata package, we can see how it works, run integration tests etc.

noisersup
noisersup previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AlekSi AlekSi dismissed stale reviews from noisersup and rumyantseva via 897daa4 September 21, 2023 17:41
@AlekSi AlekSi disabled auto-merge September 21, 2023 17:57
@AlekSi AlekSi merged commit 4e6b869 into FerretDB:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup noisersup left review comments

@rumyantseva rumyantseva rumyantseva left review comments

Assignees

@AlekSi AlekSi

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Store PostgreSQL metadata
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup