Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix params handling for dropIndexes implementation for SQLite #3350

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix params handling for dropIndexes implementation for SQLite #3350

merged 2 commits into from
Sep 13, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Sep 13, 2023 •
edited
Loading

Description

Closes #3287.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Sep 13, 2023
@rumyantseva rumyantseva added this to the Next milestone Sep 13, 2023
@rumyantseva rumyantseva self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #3350 (f848962) into main (82c1919) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
- Coverage   74.02%   73.97%   -0.05%     
==========================================
  Files         413      413              
  Lines       25282    25292      +10     
==========================================
- Hits        18714    18709       -5     
- Misses       5476     5490      +14     
- Partials     1092     1093       +1
Files Changed Coverage
internal/handlers/sqlite/msg_dropindexes.go 100.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 71.04% <100.00%> (-0.02%) ⬇️
mongodb-1 4.73% <0.00%> (-0.01%) ⬇️
pg-1 44.48% <0.00%> (-0.12%) ⬇️
pg-2 44.73% <0.00%> (-0.05%) ⬇️
pg-3 42.49% <0.00%> (-0.02%) ⬇️
sqlite-1 43.09% <0.00%> (-0.12%) ⬇️
sqlite-2 43.55% <100.00%> (+0.02%) ⬆️
sqlite-3 41.23% <38.46%> (+<0.01%) ⬆️
unit 22.91% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review September 13, 2023 08:45
@rumyantseva rumyantseva requested a review from a team as a code owner September 13, 2023 08:45
@rumyantseva rumyantseva enabled auto-merge (squash) September 13, 2023 08:46
@rumyantseva rumyantseva requested review from a team and noisersup September 13, 2023 08:46
@rumyantseva rumyantseva changed the title More accurate handling of params for dropIndexes implementation for SQLite Fix handling of params for dropIndexes implementation for SQLite Sep 13, 2023
@rumyantseva rumyantseva changed the title Fix handling of params for dropIndexes implementation for SQLite Fix params handling for dropIndexes implementation for SQLite Sep 13, 2023
chilagrow
chilagrow approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🙏

@rumyantseva rumyantseva merged commit 481bc96 into FerretDB:main Sep 13, 2023
@rumyantseva rumyantseva deleted the indexes-fix branch September 13, 2023 10:32
@AlekSi AlekSi modified the milestones: Next, v1.10.0 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement dropIndexes for SQLite
4 participants
@rumyantseva @chilagrow @noisersup @AlekSi