Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for inserting different data types #3345

Merged
merged 10 commits into from
Sep 15, 2023
Merged

Add test for inserting different data types #3345

merged 10 commits into from
Sep 15, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Sep 12, 2023 •
edited
Loading

Description

Closes #3235.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #3345 (3d8bcd3) into main (c8c8ee2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3345   +/-   ##
=======================================
  Coverage   74.11%   74.11%           
=======================================
  Files         413      413           
  Lines       25305    25305           
=======================================
  Hits        18755    18755           
  Misses       5465     5465           
  Partials     1085     1085
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 71.14% <ø> (ø)
mongodb-1 4.73% <ø> (ø)
pg-1 42.89% <ø> (-1.69%) ⬇️
pg-2 44.07% <ø> (-0.67%) ⬇️
pg-3 44.91% <ø> (+2.60%) ⬆️
sqlite-1 41.47% <ø> (-1.77%) ⬇️
sqlite-2 42.99% <ø> (-0.59%) ⬇️
sqlite-3 43.75% <ø> (+2.52%) ⬆️
unit 23.01% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Sep 14, 2023
@noisersup noisersup changed the title wip Implement test for inserting different data types Sep 14, 2023
@noisersup noisersup marked this pull request as ready for review September 14, 2023 13:40
@noisersup noisersup requested a review from a team as a code owner September 14, 2023 13:40
@noisersup noisersup requested review from AlekSi, rumyantseva, a team and chilagrow September 14, 2023 13:40
rumyantseva
rumyantseva approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you please enable auto-merge if the PR is ready for review?

@AlekSi AlekSi added this to the Next milestone Sep 15, 2023
@AlekSi AlekSi enabled auto-merge (squash) September 15, 2023 05:06
@AlekSi AlekSi changed the title Implement test for inserting different data types Add test for inserting different data types Sep 15, 2023
@AlekSi AlekSi merged commit 1c9cc3a into FerretDB:main Sep 15, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Implement filter pushdown for SQLite
4 participants
@noisersup @AlekSi @rumyantseva @chilagrow