Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ConsumeValues in the $group aggregation stage #3344

Merged
merged 23 commits into from
Sep 12, 2023
Merged

Do not ConsumeValues in the $group aggregation stage #3344

merged 23 commits into from
Sep 12, 2023

Conversation

adetunjii
Copy link
Contributor

@adetunjii adetunjii commented Sep 12, 2023 •
edited
Loading

Closes #2863.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

adetunjii and others added 22 commits May 1, 2023 20:57
@adetunjii
verify message checksum
9861d72
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
a538e85
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
6731573
@adetunjii
fix: removed todo tag for closed issue
9b978c3
@adetunjii
fix: removed todo tags for closed issues
6cc8692
@adetunjii
fix: removed todo tags for closed issues
898adb9
@adetunjii
fix: linting error
e93b955
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
3dd46a6
@AlekSi
Merge branch 'main' into main
d43517d
@adetunjii
Merge branch 'FerretDB:main' into main
05d82b9
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
e602653
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
7c91cae
@adetunjii
Merge branch 'main' of https://github.com/FerretDB/FerretDB
d36c20c
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
a820300
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
83347a3
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
a547e22
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
8979d8a
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
47374f9
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB
f642fc5
@adetunjii
Merge branches 'main' and 'main' of https://github.com/adetunjii/Ferr…
610afb7 
…etDB
@adetunjii
fix: ConsumeValues in aggreagation stage
17e1855
@adetunjii
Merge branch 'main' of https://github.com/adetunjii/FerretDB into fix…
3c786a7 
…/group-stage-consumevalues
@adetunjii adetunjii requested a review from a team as a code owner September 12, 2023 09:09
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #3344 (506f278) into main (ee5304e) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3344      +/-   ##
==========================================
- Coverage   73.94%   73.94%   -0.01%     
==========================================
  Files         413      413              
  Lines       25096    25097       +1     
==========================================
  Hits        18557    18557              
- Misses       5455     5456       +1     
  Partials     1084     1084
Files Changed Coverage
...ernal/handlers/common/aggregations/stages/group.go 66.66%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 70.95% <66.66%> (-0.01%) ⬇️
mongodb-1 4.76% <0.00%> (-0.01%) ⬇️
pg-1 44.93% <66.66%> (+0.10%) ⬆️
pg-2 45.11% <66.66%> (+<0.01%) ⬆️
pg-3 42.67% <66.66%> (+<0.01%) ⬆️
sqlite-1 43.52% <66.66%> (+<0.01%) ⬆️
sqlite-2 43.30% <66.66%> (+<0.01%) ⬆️
sqlite-3 41.23% <66.66%> (-0.06%) ⬇️
unit 23.23% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 12, 2023
@AlekSi AlekSi added this to the Next milestone Sep 12, 2023
chilagrow
chilagrow approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution!

@AlekSi AlekSi enabled auto-merge (squash) September 12, 2023 12:08
@AlekSi AlekSi changed the title Remove ConsumeValues from $group stage aggregator Do not ConsumeValues in the $group aggregation stage Sep 12, 2023
@AlekSi AlekSi modified the milestones: Next, v1.10.0 Sep 12, 2023
@AlekSi AlekSi disabled auto-merge September 12, 2023 12:34
@AlekSi AlekSi enabled auto-merge (squash) September 12, 2023 12:34
@AlekSi AlekSi merged commit 8faca75 into FerretDB:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@chilagrow chilagrow

@adetunjii adetunjii

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Do not ConsumeValues in the $group aggregation stage
3 participants
@adetunjii @AlekSi @chilagrow