Implement dropIndexes for SQLite
#3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekSi
requested changes
Sep 11, 2023
AlekSi
reviewed
Sep 11, 2023
chilagrow
reviewed
Sep 12, 2023
|
Neunundneunzig Luftballons :D |
chilagrow
reviewed
Sep 13, 2023
| for _, index := range existing { | ||
| for i, key := range index.Key { | ||
| if key.Field == spec[i].Field && key.Descending == spec[i].Descending { | ||
| return []string{index.Name}, false, nil |
There was a problem hiding this comment.
We are returning if first field matches with spec[i].Field. Don't we want to check if all Field match? 🤔
For example, if index contains two fields, it will match as long as first field is the same.
There was a problem hiding this comment.
Nice catch! Our tests didn't find it, so I think I should add a test where the first field matches and the second doesn't.
| command, | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
// TODO cannot drop ID index index == "_id_"
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
|
@rumyantseva PTAL on Chi's comments and send a follow up RP, if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3287.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.