Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Database.Close #3327

Merged
merged 8 commits into from
Sep 8, 2023
Merged

Remove Database.Close #3327

merged 8 commits into from
Sep 8, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 7, 2023

Description

Plus update documentation.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Remove Database.Close, add Database.Ping
6eb8442 
Plus update documentation.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 7, 2023
@AlekSi AlekSi self-assigned this Sep 7, 2023
@AlekSi AlekSi added this to the Next milestone Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #3327 (78be87e) into main (fb91ab1) will decrease coverage by 0.02%.
The diff coverage is 52.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   74.46%   74.44%   -0.02%     
==========================================
  Files         406      406              
  Lines       24189    24139      -50     
==========================================
- Hits        18013    17971      -42     
+ Misses       5115     5105      -10     
- Partials     1061     1063       +2
Files Changed Coverage
build/version/version.go ø
ferretdb/ferretdb.go ø
internal/backends/collection.go ø
internal/backends/decorators/dummy/backend.go 0.00%
internal/backends/decorators/dummy/database.go ø
internal/backends/decorators/oplog/backend.go 0.00%
internal/backends/decorators/oplog/database.go ø
internal/backends/postgresql/backend.go 0.00%
internal/backends/postgresql/database.go ø
internal/backends/sqlite/database.go ø
... and 24 more
Flag Coverage Δ
hana ?
integration 71.30% <56.86%> (-0.04%) ⬇️
mongodb 4.90% <0.00%> (+<0.01%) ⬆️
pg 60.75% <0.00%> (+0.11%) ⬆️
shard-1 55.32% <56.86%> (-0.08%) ⬇️
shard-2 54.34% <41.17%> (-0.05%) ⬇️
shard-3 54.22% <49.01%> (+0.05%) ⬆️
sqlite 55.89% <56.86%> (+0.08%) ⬆️
unit 23.96% <3.63%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 7, 2023
@AlekSi AlekSi changed the title Remove Database.Close, add Database.Ping Remove Database.Close Sep 7, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 7, 2023
@AlekSi AlekSi mentioned this pull request Sep 7, 2023
Merged
9 tasks
@AlekSi AlekSi marked this pull request as ready for review September 7, 2023 20:00
@AlekSi AlekSi requested a review from a team as a code owner September 7, 2023 20:00
@AlekSi AlekSi enabled auto-merge (squash) September 7, 2023 20:00
@AlekSi AlekSi requested review from a team and noisersup September 7, 2023 20:00
chilagrow
chilagrow reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test for logout appears to be fixed for SQLite now too. Let's remove FailForSQLite 🤗

@chilagrow chilagrow mentioned this pull request Sep 8, 2023
Merged
9 tasks
@AlekSi AlekSi requested review from chilagrow and a team September 8, 2023 04:25
chilagrow
chilagrow approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi disabled auto-merge September 8, 2023 04:40
@AlekSi AlekSi merged commit f3c4622 into FerretDB:main Sep 8, 2023
@AlekSi AlekSi deleted the ping-close branch September 8, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @chilagrow