Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement renameCollection for SQLite #3321

Merged
merged 14 commits into from
Sep 8, 2023
Merged

Implement renameCollection for SQLite #3321

merged 14 commits into from
Sep 8, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Sep 7, 2023 •
edited
Loading

Description

Closes #2760.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Sep 7, 2023
@chilagrow chilagrow added this to the Next milestone Sep 7, 2023
@chilagrow chilagrow self-assigned this Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #3321 (cf87825) into main (b032cd7) will increase coverage by 0.10%.
The diff coverage is 75.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
+ Coverage   73.42%   73.52%   +0.10%     
==========================================
  Files         406      406              
  Lines       24154    24310     +156     
==========================================
+ Hits        17735    17874     +139     
- Misses       5327     5337      +10     
- Partials     1092     1099       +7
Files Changed Coverage
internal/backends/sqlite/metadata/registry.go 70.73%
internal/backends/sqlite/database.go 71.42%
internal/handlers/sqlite/msg_renamecollection.go 77.35%
internal/backends/database.go 100.00%
Flag Coverage Δ
hana ?
integration 70.34% <75.14%> (+0.11%) ⬆️
mongodb 4.86% <0.00%> (-0.04%) ⬇️
pg 55.09% <0.00%> (-0.37%) ⬇️
shard-1 55.35% <42.60%> (-0.08%) ⬇️
shard-2 53.99% <3.55%> (-0.33%) ⬇️
shard-3 42.57% <75.14%> (+0.43%) ⬆️
sqlite 56.08% <75.14%> (+0.21%) ⬆️
unit 23.76% <3.55%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!.

@chilagrow chilagrow marked this pull request as ready for review September 7, 2023 09:35
@chilagrow chilagrow requested review from AlekSi and a team as code owners September 7, 2023 09:35
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup September 7, 2023 09:35
@chilagrow chilagrow enabled auto-merge (squash) September 7, 2023 09:35
@chilagrow chilagrow requested a review from AlekSi September 8, 2023 04:25
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Sep 8, 2023
AlekSi
AlekSi previously approved these changes Sep 8, 2023
View reviewed changes
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 8, 2023
@chilagrow chilagrow requested a review from AlekSi September 8, 2023 05:42
rumyantseva
rumyantseva approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks clear and correct to me! Nicely done!

@chilagrow chilagrow merged commit 1871dc9 into FerretDB:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement renameCollection for SQLite
3 participants
@chilagrow @AlekSi @rumyantseva