Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new PostgreSQL backend stub #3319

Merged
merged 53 commits into from
Sep 10, 2023
Merged

Add new PostgreSQL backend stub #3319

merged 53 commits into from
Sep 10, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 6, 2023

Description

Closes #{issue_number}.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 6, 2023
@AlekSi AlekSi self-assigned this Sep 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2023

@AlekSi this pull request has merge conflicts.

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added conflict PRs that have merge conflicts and removed conflict PRs that have merge conflicts labels Sep 8, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Sep 10, 2023
@AlekSi AlekSi added this to the Next milestone Sep 10, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 10, 2023
@AlekSi AlekSi changed the title New pg Add new PostgreSQL backend stub Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023 •
edited
Loading

Codecov Report

Merging #3319 (ea4d7db) into main (1871dc9) will decrease coverage by 0.84%.
The diff coverage is 9.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3319      +/-   ##
==========================================
- Coverage   74.53%   73.69%   -0.84%     
==========================================
  Files         406      412       +6     
  Lines       24310    24583     +273     
==========================================
- Hits        18119    18117       -2     
- Misses       5116     5389     +273     
- Partials     1075     1077       +2
Files Changed Coverage
build/version/version.go ø
integration/setup/setup.go ø
internal/backends/collection.go ø
internal/backends/database.go ø
internal/backends/postgresql/backend.go 0.00%
internal/backends/postgresql/metadata/metadata.go 0.00%
...ternal/backends/postgresql/metadata/pool/opendb.go 0.00%
internal/backends/postgresql/metadata/pool/pool.go 0.00%
internal/backends/postgresql/metadata/pool/uri.go 0.00%
internal/backends/postgresql/metadata/registry.go 0.00%
... and 12 more
Flag Coverage Δ
hana ?
integration 70.61% <8.05%> (-0.83%) ⬇️
mongodb ?
mongodb-1 4.81% <0.00%> (?)
pg ?
pg-1 45.19% <0.67%> (?)
pg-2 44.75% <0.67%> (?)
pg-3 44.66% <0.67%> (?)
shard-1 ?
shard-2 ?
shard-3 ?
sqlite ?
sqlite-1 42.19% <8.05%> (?)
sqlite-2 41.70% <8.05%> (?)
sqlite-3 42.12% <8.05%> (?)
unit 23.46% <6.08%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review September 10, 2023 13:05
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners September 10, 2023 13:05
@AlekSi AlekSi merged commit 4af1da0 into FerretDB:main Sep 10, 2023
@AlekSi AlekSi deleted the new-pg branch September 10, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
1 participant
@AlekSi