Cleanup $bit update operator
#3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
+ Coverage 74.03% 74.19% +0.16%
==========================================
Files 400 400
Lines 23995 23970 -25
==========================================
+ Hits 17764 17785 +21
+ Misses 5146 5105 -41
+ Partials 1085 1080 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
added
the
documentation
chilagrow
changed the title
$bit update operator$bit update operator
|
Reorganised code and removed unreachable code, this increased test coverage too. https://app.codecov.io/gh/FerretDB/FerretDB/pull/3315/blob/internal/handlers/common/update.go#L757 |
|
👋 @adetunjii I reorganised the code and also added tests for each BSON type. |
AlekSi
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #821.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.