Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up *types.Timestamp a bit #3305

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Clean-up *types.Timestamp a bit #3305

merged 2 commits into from
Sep 5, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 4, 2023

Description

Needed for the future PR.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Needed for the future PR.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Sep 4, 2023
@AlekSi AlekSi added this to the Next milestone Sep 4, 2023
@AlekSi AlekSi self-assigned this Sep 4, 2023
@AlekSi AlekSi requested a review from a team as a code owner September 4, 2023 18:21
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup September 4, 2023 18:21
@AlekSi AlekSi enabled auto-merge (squash) September 4, 2023 18:21
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #3305 (3e8dd1f) into main (4e8aba9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3305      +/-   ##
==========================================
+ Coverage   75.17%   75.22%   +0.05%     
==========================================
  Files         400      400              
  Lines       23374    23374              
==========================================
+ Hits        17571    17583      +12     
+ Misses       4773     4764       -9     
+ Partials     1030     1027       -3     
Files Changed Coverage
integration/helpers.go 100.00%
internal/types/timestamp.go 100.00%
Flag Coverage Δ
hana ?
integration 71.81% <100.00%> (+0.01%) ⬆️
mongodb 5.04% <22.22%> (-0.02%) ⬇️
pg 61.96% <100.00%> (-0.04%) ⬇️
shard-1 56.58% <22.22%> (-0.02%) ⬇️
shard-2 55.64% <100.00%> (ø)
shard-3 54.39% <22.22%> (+0.04%) ⬆️
sqlite 55.45% <100.00%> (+0.05%) ⬆️
unit 24.83% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine. CI is failing though.

@AlekSi AlekSi requested review from chilagrow and a team September 5, 2023 03:38
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AlekSi AlekSi disabled auto-merge September 5, 2023 08:53
@AlekSi AlekSi merged commit 1262111 into FerretDB:main Sep 5, 2023
@AlekSi AlekSi deleted the timestamp branch September 5, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants