Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement createIndexes for SQLite #3304

Merged
merged 75 commits into from
Sep 10, 2023
Merged

Implement createIndexes for SQLite #3304

merged 75 commits into from
Sep 10, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Sep 4, 2023 •
edited
Loading

Description

Closes #3176.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #3304 (6f5dbac) into main (4af1da0) will increase coverage by 0.12%.
The diff coverage is 80.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3304      +/-   ##
==========================================
+ Coverage   73.75%   73.88%   +0.12%     
==========================================
  Files         412      413       +1     
  Lines       24583    25034     +451     
==========================================
+ Hits        18131    18496     +365     
- Misses       5379     5456      +77     
- Partials     1073     1082       +9
Files Changed Coverage
internal/backends/decorators/dummy/collection.go 0.00%
internal/backends/decorators/oplog/collection.go 0.00%
internal/backends/postgresql/collection.go 0.00%
internal/backends/sqlite/metadata/metadata.go 56.81%
internal/backends/sqlite/metadata/registry.go 76.33%
internal/handlers/sqlite/msg_createindexes.go 83.89%
internal/backends/collection.go 100.00%
internal/backends/sqlite/collection.go 100.00%
internal/backends/sqlite/metadata/pool/pool.go 100.00%
Flag Coverage Δ
hana-1 ?
hana-2 ?
hana-3 ?
integration 70.87% <80.49%> (+0.20%) ⬆️
mongodb-1 4.72% <0.00%> (-0.09%) ⬇️
pg-1 44.40% <0.00%> (-0.83%) ⬇️
pg-2 43.94% <0.00%> (-0.82%) ⬇️
pg-3 43.90% <0.00%> (-0.92%) ⬇️
sqlite-1 42.78% <72.65%> (+0.55%) ⬆️
sqlite-2 41.93% <56.40%> (+0.22%) ⬆️
sqlite-3 42.14% <54.49%> (+0.12%) ⬆️
unit 23.29% <17.71%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added this to the Next milestone Sep 8, 2023
@rumyantseva rumyantseva requested review from a team, chilagrow and noisersup September 8, 2023 08:22
@rumyantseva rumyantseva marked this pull request as ready for review September 8, 2023 08:22
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners September 8, 2023 08:22
@rumyantseva rumyantseva enabled auto-merge (squash) September 8, 2023 08:23
chilagrow
chilagrow reviewed Sep 8, 2023
View reviewed changes
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Show resolved Hide resolved
AlekSi
AlekSi reviewed Sep 8, 2023
View reviewed changes
integration/explain_compat_test.go Show resolved Hide resolved
integration/indexes_command_compat_test.go Outdated Show resolved Hide resolved
integration/indexes_command_test.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/error.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Show resolved Hide resolved
internal/backends/validation.go Outdated Show resolved Hide resolved
@rumyantseva
Copy link
Contributor Author

rumyantseva commented Sep 8, 2023 •
edited
Loading

Ok, the problem with unit tests is because of TestCreateSameStress doesn't work. I don't see what exactly happens, the way how mutex is used looks correct to me, so I'm still investigating the problems. Suggestions are welcome.

@AlekSi AlekSi disabled auto-merge September 10, 2023 20:47
@AlekSi AlekSi merged commit 684177a into FerretDB:main Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement createIndexes for SQLite
3 participants
@rumyantseva @AlekSi @chilagrow