Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement findAndModify for SQLite #3302

Merged
merged 13 commits into from
Sep 6, 2023
Merged

Implement findAndModify for SQLite #3302

merged 13 commits into from
Sep 6, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Sep 4, 2023 •
edited
Loading

Description

Closes #3049.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Sep 4, 2023
@chilagrow chilagrow added this to the Next milestone Sep 4, 2023
@chilagrow chilagrow self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #3302 (763dab0) into main (128fa84) will decrease coverage by 1.36%.
The diff coverage is 63.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
- Coverage   75.24%   73.89%   -1.36%     
==========================================
  Files         400      400              
  Lines       23559    23805     +246     
==========================================
- Hits        17727    17590     -137     
- Misses       4801     5145     +344     
- Partials     1031     1070      +39
Files Changed Coverage
internal/handlers/sqlite/msg_findandmodify.go 63.30%
Flag Coverage Δ
integration 70.39% <63.30%> (-1.47%) ⬇️
mongodb 4.95% <0.00%> (-0.06%) ⬇️
pg 56.14% <0.00%> (-5.95%) ⬇️
shard-1 55.99% <49.59%> (-0.10%) ⬇️
shard-2 41.71% <50.80%> (-13.13%) ⬇️
shard-3 54.86% <53.22%> (+0.01%) ⬆️
sqlite 55.97% <63.30%> (+0.31%) ⬆️
unit 24.30% <0.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow mentioned this pull request Sep 5, 2023
Closed
@chilagrow chilagrow mentioned this pull request Sep 5, 2023
Open
@chilagrow chilagrow marked this pull request as ready for review September 5, 2023 09:34
@chilagrow chilagrow requested a review from a team as a code owner September 5, 2023 09:34
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup September 5, 2023 09:34
@chilagrow chilagrow enabled auto-merge (squash) September 5, 2023 09:35
rumyantseva
rumyantseva approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's reasonable to merge these changes. Thanks for the walkthrough!

@chilagrow chilagrow merged commit ed54533 into FerretDB:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement findAndModify for SQLite
3 participants
@chilagrow @AlekSi @rumyantseva