Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement listIndexes for SQLite #3301

Merged
merged 29 commits into from
Sep 7, 2023
Merged

Implement listIndexes for SQLite #3301

merged 29 commits into from
Sep 7, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Sep 4, 2023 •
edited
Loading

Description

Closes #3175.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Sep 4, 2023
@rumyantseva rumyantseva changed the title added basic data types Support listIndexes for SQLite backend Sep 4, 2023
@rumyantseva rumyantseva added the code/feature Some user-visible feature is not implemented yet label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #3301 (3e5fd63) into main (91ddcc9) will increase coverage by 1.34%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3301      +/-   ##
==========================================
+ Coverage   73.70%   75.05%   +1.34%     
==========================================
  Files         400      400              
  Lines       23889    23995     +106     
==========================================
+ Hits        17607    18009     +402     
+ Misses       5197     4925     -272     
+ Partials     1085     1061      -24
Files Changed Coverage
internal/backends/postgresql/collection.go 0.00%
internal/handlers/sqlite/msg_listindexes.go 61.11%
internal/backends/collection.go 100.00%
internal/backends/sqlite/collection.go 100.00%
Flag Coverage Δ
hana ?
integration 71.74% <72.22%> (+1.47%) ⬆️
mongodb 4.92% <0.00%> (-0.03%) ⬇️
pg 60.94% <0.00%> (+5.23%) ⬆️
shard-1 55.71% <66.66%> (-0.31%) ⬇️
shard-2 54.73% <66.66%> (+9.00%) ⬆️
shard-3 54.41% <72.22%> (+11.51%) ⬆️
sqlite 56.12% <72.22%> (+4.73%) ⬆️
unit 24.10% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Sep 4, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 4, 2023
@rumyantseva rumyantseva added this to the Next milestone Sep 4, 2023
@rumyantseva rumyantseva marked this pull request as ready for review September 4, 2023 12:38
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners September 4, 2023 12:38
@rumyantseva rumyantseva enabled auto-merge (squash) September 4, 2023 12:38
@rumyantseva rumyantseva requested review from a team and noisersup September 4, 2023 12:39
@rumyantseva rumyantseva changed the title Support listIndexes for SQLite backend Support listIndexes for SQLite Sep 4, 2023
@rumyantseva rumyantseva changed the title Support listIndexes for SQLite Implement listIndexes for SQLite Sep 4, 2023
chilagrow
chilagrow reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments

internal/backends/collection.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_listindexes.go Outdated Show resolved Hide resolved
@AlekSi AlekSi requested review from a team September 5, 2023 17:38
AlekSi
AlekSi reviewed Sep 5, 2023
View reviewed changes
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_listindexes.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_listindexes.go Outdated Show resolved Hide resolved
internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
chilagrow
chilagrow reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's apply @AlekSi's comment, otherwise looks good

chilagrow
chilagrow previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

chilagrow
chilagrow previously approved these changes Sep 6, 2023
View reviewed changes
AlekSi
AlekSi reviewed Sep 6, 2023
View reviewed changes
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/collection.go Outdated Show resolved Hide resolved
internal/backends/sqlite/collection.go Outdated Show resolved Hide resolved
Elena Grahovac and others added 4 commits September 6, 2023 17:39
@AlekSi
Update internal/backends/collection.go
eff4dfd 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@AlekSi
Update internal/backends/collection.go
7f29967 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@rumyantseva
wip
8f14c4f
@rumyantseva
wip
ef8717d
@AlekSi AlekSi requested review from a team September 6, 2023 18:04
chilagrow
chilagrow approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rumyantseva rumyantseva merged commit 586e27b into FerretDB:main Sep 7, 2023
@rumyantseva rumyantseva deleted the issue-3175-list-indexes branch September 7, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement listIndexes for SQLite
3 participants
@rumyantseva @AlekSi @chilagrow