Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not change search_path parameter #3299

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Do not change search_path parameter #3299

merged 5 commits into from
Sep 4, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Sep 4, 2023 •
edited
Loading

Description

That makes it easier to use FerretDB with another proxy or other backends. See #3252 (comment).

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Sep 4, 2023
@AlekSi AlekSi added this to the Next milestone Sep 4, 2023
@AlekSi AlekSi self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #3299 (672af1f) into main (e3774a9) will decrease coverage by 0.01%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3299      +/-   ##
==========================================
- Coverage   75.15%   75.14%   -0.01%     
==========================================
  Files         400      400              
  Lines       23201    23196       -5     
==========================================
- Hits        17436    17431       -5     
+ Misses       4749     4748       -1     
- Partials     1016     1017       +1
Files Changed Coverage
internal/util/debugbuild/debugbuild.go ø
internal/backends/sqlite/metadata/pool/pool.go 37.50%
internal/handlers/common/setfreemonitoring.go 40.00%
internal/handlers/pg/pgdb/pool.go 42.85%
ferretdb/ferretdb.go 100.00%
Flag Coverage Δ
hana ?
integration 71.70% <34.78%> (-0.01%) ⬇️
mongodb 5.10% <0.00%> (+<0.01%) ⬆️
pg 62.44% <21.73%> (+<0.01%) ⬆️
shard-1 55.76% <34.78%> (+0.15%) ⬆️
shard-2 54.47% <26.08%> (-0.01%) ⬇️
shard-3 55.95% <26.08%> (-0.01%) ⬇️
sqlite 55.09% <21.73%> (+<0.01%) ⬆️
unit 24.87% <39.13%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review September 4, 2023 05:23
@AlekSi AlekSi requested a review from a team as a code owner September 4, 2023 05:23
@AlekSi AlekSi enabled auto-merge (squash) September 4, 2023 05:23
@AlekSi AlekSi requested review from a team and noisersup September 4, 2023 05:23
rumyantseva
rumyantseva approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 76c3b68 into FerretDB:main Sep 4, 2023
@AlekSi AlekSi deleted the search-path branch September 4, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow