Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make updates atomic for SQLite #3296

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Make updates atomic for SQLite #3296

merged 6 commits into from
Sep 1, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 31, 2023 •
edited
Loading

Description

Clean up the backend part. The handler part probably should be updated during findAndModify work.

Closes #3079.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 31, 2023
@AlekSi AlekSi self-assigned this Aug 31, 2023
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 31, 2023
@AlekSi AlekSi added this to the Next milestone Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #3296 (39b6d92) into main (2be310a) will decrease coverage by 0.01%.
The diff coverage is 69.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   75.22%   75.21%   -0.01%     
==========================================
  Files         400      400              
  Lines       23008    23007       -1     
==========================================
- Hits        17307    17304       -3     
- Misses       4697     4700       +3     
+ Partials     1004     1003       -1
Files Changed Coverage
internal/backends/postgresql/collection.go 0.00%
internal/backends/sqlite/database.go ø
internal/handlers/common/delete_params.go ø
internal/backends/sqlite/collection.go 52.17%
internal/backends/sqlite/metadata/pool/pool.go 85.71%
internal/backends/collection.go 100.00%
internal/backends/sqlite/metadata/pool/uri.go 100.00%
internal/handlers/common/update_params.go 100.00%
internal/handlers/sqlite/msg_update.go 100.00%
Flag Coverage Δ
hana ?
integration 71.74% <67.44%> (-0.04%) ⬇️
mongodb 5.14% <0.00%> (+<0.01%) ⬆️
pg 62.94% <4.65%> (-0.03%) ⬇️
shard-1 56.07% <67.44%> (-0.02%) ⬇️
shard-2 54.73% <67.44%> (-0.06%) ⬇️
shard-3 55.88% <67.44%> (-0.01%) ⬇️
sqlite 54.87% <67.44%> (-0.01%) ⬇️
unit 25.08% <16.27%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup August 31, 2023 12:01
@AlekSi AlekSi marked this pull request as ready for review August 31, 2023 12:01
@AlekSi AlekSi enabled auto-merge (squash) August 31, 2023 12:01
@AlekSi AlekSi mentioned this pull request Aug 31, 2023
Closed
9 tasks
rumyantseva
rumyantseva approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

chilagrow
chilagrow approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@AlekSi AlekSi merged commit de67252 into FerretDB:main Sep 1, 2023
@AlekSi AlekSi deleted the sqlite-update branch September 1, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Cleanup and optimize updates
3 participants
@AlekSi @rumyantseva @chilagrow